56349[FEATURE] Add HTTPS security check to reports module
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Benjamin Franzke +1
- Mathias Schreiber +1
- Tobi Kretschmann +1
- Jan Helke +1
-
Verified V +2
- Georg Ringer +2
- Benjamin Franzke +1
- Mathias Schreiber +1
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Feature-84466-RequestAwareInterfacesAddedToReports.rstnew+30 −0
- typo3/sysext/reports/Classes/Controller/ReportController.php+8 −1
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php6+65 −15
- typo3/sysext/reports/Classes/Report/Status/Status.php1+16 −7
- typo3/sysext/reports/Classes/RequestAwareReportInterface.phpnew+32 −0
- typo3/sysext/reports/Classes/RequestAwareStatusProviderInterface.phpnew+32 −0
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf+6 −0
Review log 3549
Show 1524 earlier messages
-
Mathias Brodala uploaded patch set 1 03/18/18, 11:32
-
Mathias Brodala uploaded patch set 2 03/18/18, 11:33
-
TYPO3com voted on patch set 1 V +1 03/18/18, 11:44 Completed build in 11m 45s on Sun, 18 Mar, 12:44 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21634
-
TYPO3com voted on patch set 2 V +1 03/18/18, 11:45 Completed build in 12m 00s on Sun, 18 Mar, 12:45 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21635
-
Mathias Brodala uploaded patch set 3 03/18/18, 12:28
-
Mathias Brodala uploaded patch set 4 03/18/18, 12:34
-
TYPO3com voted on patch set 3 V +1 03/18/18, 12:39 Completed build in 11m 05s on Sun, 18 Mar, 01:39 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21648
-
TYPO3com voted on patch set 4 V +1 03/18/18, 12:44 Completed build in 09m 28s on Sun, 18 Mar, 01:44 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21650
-
Christian Kuhn uploaded patch set 5 03/18/18, 12:49
-
Jan Helke voted on patch set 5 V +1 CR +1 03/18/18, 12:50
-
Mathias Brodala commented on patch set 6 03/18/18, 12:51
Published edit on patch set 5. -
Mathias Brodala commented on patch set 7 03/18/18, 12:53
Published edit on patch set 6. -
Jan Helke voted on patch set 7 V +1 CR +1 03/18/18, 12:53
-
TYPO3com voted on patch set 5 V +1 03/18/18, 13:00 Completed build in 11m 08s on Sun, 18 Mar, 02:00 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21652
-
TYPO3com voted on patch set 6 V +1 03/18/18, 13:01 Completed build in 10m 29s on Sun, 18 Mar, 02:01 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21653
-
TYPO3com voted on patch set 7 V +1 03/18/18, 13:05 Completed build in 12m 07s on Sun, 18 Mar, 02:05 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21654
-
Benjamin Franzke commented on patch set 7 03/18/18, 14:33
SecurityStatus.php:38IMO the ServerRequestInterface object should rather be passed as argument to getStatus.Status.php:55UnresolvedSame here, the request should be passed as argument. The reason is to provide stateless reports. -
Mathias Brodala commented on patch set 7 03/18/18, 14:36
SecurityStatus.php:38ReplyOf course that's an option but this would lead to a breaking change since we'd need to change the StatusProviderInterface. That's why I came up with the additional interface. -
Benjamin Franzke uploaded patch set 8 03/18/18, 14:54
-
TYPO3com voted on patch set 8 V -1 03/18/18, 14:55 Completed build in 09s on Sun, 18 Mar, 03:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21660
-
Benjamin Franzke uploaded patch set 9 03/18/18, 14:56
-
Benjamin Franzke commented on patch set 8 03/18/18, 14:57
SecurityStatus.php:38ReplyI think that's possible without a breaking change. I've uploaded patchset 8 which does that. -
TYPO3com voted on patch set 9 V +1 03/18/18, 15:06 Completed build in 09m 16s on Sun, 18 Mar, 04:06 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21661
-
Mathias Brodala commented on patch set 7 03/18/18, 15:10
SecurityStatus.php:38ReplyYou are right, this also works. I'd still prefer the new interfaces (which mimic what LoggerAwareInterface does) but will wait what the general consensus will be.
-
Benjamin Franzke commented on patch set 9 03/18/18, 19:21
SecurityStatus.php:38ReplyI think there is quite a difference between a logger and the request: the logger is part of the application/pipeline (and is theoretically reusable for many requests – ignoring the request-id for now) while the request is payload. While services are fine to be injected into classes, I would not inject payload into services. That is because my long term goal for the TYPO3 application it to be usable as true pipeline: It receives a requests, processes it and returns a response. Services should be reusable for many requests, as that will help for subrequests and non-forking functional tests. Sure, there may be classes that derive from the request, but those are not services, but rather data (like the normalized attributes object). I would classify the report classes as services and therefore pass the request as argument. I think the distinction becomes clear when you think how an event-loop based server (C, nodejs, if you're familar with one of those) needs to be structured to be able to process multiple requests. -
Georg Ringer commented on patch set 9 CR -1 03/19/18, 06:57
pls split that up in 2 patches, especially if one is about a feature, it should contain the feature's code only -
Mathias Brodala commented on patch set 7 03/19/18, 08:10
SecurityStatus.php:38Reply UnresolvedAfter giving this some thought I think you are right. Requests objects are basically a DTO which is not something which should be injected. BTW: since we must change to ReportInterface::getReport(ServerRequestInterface $request = null) we will have a breaking change nevertheless. This means we must add new interfaces if we want to forward the current request. -
Tobi Kretschmann voted on patch set 9 CR +1 03/19/18, 08:24
-
Benjamin Franzke uploaded patch set 10 03/19/18, 09:31
-
Benjamin Franzke updated the commit message in patch set 11 03/19/18, 09:32
-
Benjamin Franzke commented on patch set 10 03/19/18, 09:34
> pls split that up in 2 patches, especially if one is about a feature, it should contain the feature's code only There are not two things here: the interfaces need to be extended to support non-global request-awareness. I've updated the commit message to reflect, that the interface changes are not drive-by changes, but actually required. -
Mathias Brodala commented on patch set 12 03/19/18, 09:38
Published edit on patch set 11. -
TYPO3com voted on patch set 12 V -1 03/19/18, 09:38 Completed build in 10s on Mon, 19 Mar, 10:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21678
-
Mathias Brodala commented on patch set 13 03/19/18, 09:38
Published edit on patch set 12. -
TYPO3com voted on patch set 10 V -1 03/19/18, 09:41 Completed build in 10m 19s on Mon, 19 Mar, 10:41 AM Test Summary: 1 of 31034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21676
-
TYPO3com voted on patch set 11 V +1 03/19/18, 09:44 Completed build in 12m 08s on Mon, 19 Mar, 10:44 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21677
-
TYPO3com voted on patch set 13 V +1 03/19/18, 09:47 Completed build in 09m 00s on Mon, 19 Mar, 10:47 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21679
-
Benjamin Franzke voted on patch set 13 V +1 CR +1 03/19/18, 09:49
-
Tobi Kretschmann voted on patch set 13 CR +1 03/19/18, 09:52
-
Mathias Brodala commented on patch set 14 03/19/18, 09:53
Published edit on patch set 13. -
Benjamin Franzke voted on patch set 14 V +1 CR +1 03/19/18, 09:53
-
Tobi Kretschmann voted on patch set 14 CR +1 03/19/18, 09:59
-
TYPO3com voted on patch set 14 V +1 03/19/18, 10:02 Completed build in 09m 25s on Mon, 19 Mar, 11:02 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21683
-
Mathias Schreiber voted on patch set 14 V +1 CR +1 03/22/18, 08:49
-
Jan Helke voted on patch set 14 V +1 CR +1 03/22/18, 09:16
-
Tymoteusz Motylewski commented on patch set 14 03/23/18, 21:49
Im new in the PSR party, but do I understand correctly that there is no other way to access server requedt than getting it passed from the controller? Shouldnt we have some generic method to access server request from arbitraty place? Or is ot bad practice? -
Mathias Brodala commented on patch set 14 03/26/18, 07:31
> Im new in the PSR party, but do I understand correctly that there > is no other way to access server requedt than getting it passed > from the controller? Shouldnt we have some generic method to access > server request from arbitraty place? Or is ot bad practice? Exactly. We currently do have a global variable which helps us with the migration to PSR-7 everywhere but it's bound to be removed ASAP. Accessing state via global variables is bad in many ways wrt to encapsulation and the principle of least surprise as well as the danger of modifying said global state. In general a server request is passed in to a controller and then should be forwarded to every location which needs data from that. If you have a specific usecase you can extract data from the request in the controller and forward that of course but in this specific case we cannot know what data a report and status provider may need which is why the whole request is forwarded. Notice that PSR-7 requests are immutable by definition (at least as far as PHP allows) so the issues mentioned above don't apply here. -
Georg Ringer voted on patch set 14 V +2 CR +2 03/26/18, 10:50
-
Georg Ringer merged patch set 15 03/26/18, 10:50