Review TYPO3_8-7 Merged

56352[BUGFIX] Unify the filename sanitation for upload, create, rename

Andreas Wolf CR +2 V +2 Easy +19 −11 updated 04/27/18, 06:09

Commit message

isValidFilename allows other characters in file names
than sanitizeFileName. This patch sanitizes new file
names automatically (like it’s done for uploads) and
adds a warning for the user about the invalid original
file name for upload, create and rename.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Andreas Wolf uploaded patch set 1 03/18/18, 11:53

  2. TYPO3com voted on patch set 1 V +1 03/18/18, 12:07 Completed build in 13m 58s on Sun, 18 Mar, 01:07 PM Test Summary: 58219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2138

  3. Stephan Großberndt commented on patch set 1 04/03/18, 15:48

    This looks like it was a straight backport? If not, test?
  4. Andreas Wolf commented on patch set 1 V +2 CR +2 04/27/18, 06:09

    Indeed, I'll merge it now.
  5. Andreas Wolf merged patch set 2 04/27/18, 06:09