56358[TASK] Extract request processing from OpendocsToolbarItem
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php4+108 −157
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.phpnew+78 −0
- typo3/sysext/opendocs/Classes/Service/OpenDocumentService.phpnew+117 −0
- typo3/sysext/opendocs/Configuration/Backend/AjaxRoutes.php+2 −2
- typo3/sysext/opendocs/Tests/Unit/Service/OpenDocumentServiceTest.phpnew+156 −0
Review log 2334
Show 59 earlier messages
-
Mathias Brodala uploaded patch set 1 03/18/18, 14:14
-
TYPO3com voted on patch set 1 V +1 03/18/18, 14:23 Completed build in 09m 03s on Sun, 18 Mar, 03:23 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21657
-
Mathias Brodala uploaded patch set 2 03/18/18, 14:32
-
TYPO3com voted on patch set 2 V +1 03/18/18, 14:40 Completed build in 08m 19s on Sun, 18 Mar, 03:40 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21658
-
Mathias Brodala uploaded patch set 3 03/18/18, 14:41
-
TYPO3com voted on patch set 3 V +1 03/18/18, 14:49 Completed build in 08m 30s on Sun, 18 Mar, 03:49 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21659
-
Mathias Brodala uploaded patch set 4 03/18/18, 15:15
-
TYPO3com voted on patch set 4 V -1 03/18/18, 15:15 Completed build in 11s on Sun, 18 Mar, 04:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21663
-
Mathias Brodala commented on patch set 5 03/18/18, 15:17
Published edit on patch set 4.
-
TYPO3com voted on patch set 5 V +1 03/18/18, 15:26 Completed build in 08m 21s on Sun, 18 Mar, 04:26 PM Test Summary: 30897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21664
-
Stefan Neufeind commented on patch set 5 03/18/18, 18:44
DocumentsController.php:59comment cropped here? -
Mathias Brodala commented on patch set 5 03/19/18, 07:59
DocumentsController.php:59ReplyIt's meant to build up the tension. ;-) -
Mathias Brodala commented on patch set 6 03/19/18, 08:00
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V -1 03/19/18, 08:00 Completed build in 10s on Mon, 19 Mar, 09:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21673
-
Mathias Brodala commented on patch set 7 03/19/18, 08:00
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V +1 03/19/18, 08:10 Completed build in 09m 32s on Mon, 19 Mar, 09:10 AM Test Summary: 30897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21674
-
Jörg Bösche commented on patch set 6 03/26/18, 08:17
OpendocsToolbarItem.php:62Are we type safe here? You have removed the (int) cast. The data comes from the typoscript configuration. I'm not sure, if we have an integer or a string with "0" or "1" here.OpendocsToolbarItem.php:185The method has a second parameter $arguments. Can we pass the $document[2] data here instead of concatenate the data? -
Mathias Brodala commented on patch set 6 03/26/18, 08:43
OpendocsToolbarItem.php:62ReplyYou are right, I misinterpreted the original code, will fix.OpendocsToolbarItem.php:185ReplyWe can probably improve a lot here but for now I'd like to migrate without too many changes which can cause regressions. (See the (int) cast in your other comment. ;-) ) -
Mathias Brodala commented on patch set 8 03/26/18, 08:44
Published edit on patch set 7. -
Mathias Brodala commented on patch set 8 03/26/18, 08:44
Restored type cast. -
TYPO3com voted on patch set 8 V +1 03/26/18, 08:53 Completed build in 08m 59s on Mon, 26 Mar, 10:53 AM Test Summary: 30906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21811
-
Tobi Kretschmann commented on patch set 8 03/26/18, 09:26
Documents.php:33is the parameter necessary? Currently no implementation passes an instance of BackendUserAuthentication. -
Mathias Brodala commented on patch set 8 03/26/18, 09:29
Documents.php:33Reply UnresolvedThis variant makes it very easy to inject a mock for tests. The protected getter variant requires me to mock part of the subject itself. -
Christian Kuhn commented on patch set 8 CR -1 03/29/18, 14:13
i'm not too happy with the class namings: Documents is imho too generic and i'd like that to be more specific to avoid confusion. I'll push a new patch to change that a bit. -
Mathias Brodala commented on patch set 8 03/29/18, 14:24
> i'm not too happy with the class namings: Documents is imho too > generic and i'd like that to be more specific to avoid confusion. > I'll push a new patch to change that a bit. Absolutely fine with me. You know how hard it is to name things. ;-) -
Christian Kuhn uploaded patch set 9 03/29/18, 14:41
-
TYPO3com voted on patch set 9 V -1 03/29/18, 14:41 Completed build in 09s on Thu, 29 Mar, 04:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21860
-
Christian Kuhn uploaded patch set 10 03/29/18, 14:43
-
TYPO3com voted on patch set 10 V -1 03/29/18, 14:43 Completed build in 09s on Thu, 29 Mar, 04:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21861
-
Christian Kuhn uploaded patch set 11 03/29/18, 14:49
-
TYPO3com voted on patch set 11 V +1 03/29/18, 14:58 Completed build in 08m 54s on Thu, 29 Mar, 04:58 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21863
-
Frank Nägler voted on patch set 11 V +1 CR +1 03/29/18, 15:17
-
Christian Kuhn voted on patch set 11 V +2 CR +2 03/29/18, 15:17
-
Christian Kuhn merged patch set 12 03/29/18, 15:17