Review main Merged

56358[TASK] Extract request processing from OpendocsToolbarItem

Mathias Brodala CR +2 V +2 Hard +461 −159 updated 03/29/18, 15:17

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2334

Show 59 earlier messages
  1. Mathias Brodala uploaded patch set 1 03/18/18, 14:14

  2. TYPO3com voted on patch set 1 V +1 03/18/18, 14:23 Completed build in 09m 03s on Sun, 18 Mar, 03:23 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21657

  3. Mathias Brodala uploaded patch set 2 03/18/18, 14:32

  4. TYPO3com voted on patch set 2 V +1 03/18/18, 14:40 Completed build in 08m 19s on Sun, 18 Mar, 03:40 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21658

  5. Mathias Brodala uploaded patch set 3 03/18/18, 14:41

  6. TYPO3com voted on patch set 3 V +1 03/18/18, 14:49 Completed build in 08m 30s on Sun, 18 Mar, 03:49 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21659

  7. Mathias Brodala uploaded patch set 4 03/18/18, 15:15

  8. TYPO3com voted on patch set 4 V -1 03/18/18, 15:15 Completed build in 11s on Sun, 18 Mar, 04:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21663

  9. Mathias Brodala commented on patch set 5 03/18/18, 15:17

    Published edit on patch set 4.
  1. TYPO3com voted on patch set 5 V +1 03/18/18, 15:26 Completed build in 08m 21s on Sun, 18 Mar, 04:26 PM Test Summary: 30897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21664

  2. Stefan Neufeind commented on patch set 5 03/18/18, 18:44

    DocumentsController.php:59

    comment cropped here?
  3. Mathias Brodala commented on patch set 5 03/19/18, 07:59

    DocumentsController.php:59 Reply

    It's meant to build up the tension. ;-)
  4. Mathias Brodala commented on patch set 6 03/19/18, 08:00

    Published edit on patch set 5.
  5. TYPO3com voted on patch set 6 V -1 03/19/18, 08:00 Completed build in 10s on Mon, 19 Mar, 09:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21673

  6. Mathias Brodala commented on patch set 7 03/19/18, 08:00

    Published edit on patch set 6.
  7. TYPO3com voted on patch set 7 V +1 03/19/18, 08:10 Completed build in 09m 32s on Mon, 19 Mar, 09:10 AM Test Summary: 30897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21674

  8. Jörg Bösche commented on patch set 6 03/26/18, 08:17

    OpendocsToolbarItem.php:62

    Are we type safe here? You have removed the (int) cast. The data comes from the typoscript configuration. I'm not sure, if we have an integer or a string with "0" or "1" here.

    OpendocsToolbarItem.php:185

    The method has a second parameter $arguments. Can we pass the $document[2] data here instead of concatenate the data?
  9. Mathias Brodala commented on patch set 6 03/26/18, 08:43

    OpendocsToolbarItem.php:62 Reply

    You are right, I misinterpreted the original code, will fix.

    OpendocsToolbarItem.php:185 Reply

    We can probably improve a lot here but for now I'd like to migrate without too many changes which can cause regressions. (See the (int) cast in your other comment. ;-) )
  10. Mathias Brodala commented on patch set 8 03/26/18, 08:44

    Published edit on patch set 7.
  11. Mathias Brodala commented on patch set 8 03/26/18, 08:44

    Restored type cast.
  12. TYPO3com voted on patch set 8 V +1 03/26/18, 08:53 Completed build in 08m 59s on Mon, 26 Mar, 10:53 AM Test Summary: 30906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21811

  13. Tobi Kretschmann commented on patch set 8 03/26/18, 09:26

    Documents.php:33

    is the parameter necessary? Currently no implementation passes an instance of BackendUserAuthentication.
  14. Mathias Brodala commented on patch set 8 03/26/18, 09:29

    Documents.php:33 Reply Unresolved

    This variant makes it very easy to inject a mock for tests. The protected getter variant requires me to mock part of the subject itself.
  15. Christian Kuhn commented on patch set 8 CR -1 03/29/18, 14:13

    i'm not too happy with the class namings: Documents is imho too generic and i'd like that to be more specific to avoid confusion. I'll push a new patch to change that a bit.
  16. Mathias Brodala commented on patch set 8 03/29/18, 14:24

    > i'm not too happy with the class namings: Documents is imho too > generic and i'd like that to be more specific to avoid confusion. > I'll push a new patch to change that a bit. Absolutely fine with me. You know how hard it is to name things. ;-)
  17. Christian Kuhn uploaded patch set 9 03/29/18, 14:41

  18. TYPO3com voted on patch set 9 V -1 03/29/18, 14:41 Completed build in 09s on Thu, 29 Mar, 04:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21860

  19. Christian Kuhn uploaded patch set 10 03/29/18, 14:43

  20. TYPO3com voted on patch set 10 V -1 03/29/18, 14:43 Completed build in 09s on Thu, 29 Mar, 04:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21861

  21. Christian Kuhn uploaded patch set 11 03/29/18, 14:49

  22. TYPO3com voted on patch set 11 V +1 03/29/18, 14:58 Completed build in 08m 54s on Thu, 29 Mar, 04:58 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21863

  23. Frank Nägler voted on patch set 11 V +1 CR +1 03/29/18, 15:17

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 03/29/18, 15:17

  25. Christian Kuhn merged patch set 12 03/29/18, 15:17