Review main Merged

56369[BUGFIX] Remove wrong break; statement in rootline check

Georg Ringer CR +2 V +2 Easy +0 −1 updated 04/09/18, 07:13

Commit message

With issue #81280 a break statement has been added which breaks
the check of permissons "extend to subpage".

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Georg Ringer uploaded patch set 1 03/19/18, 19:09

  2. Markus Klein voted on patch set 1 V +1 CR +1 03/19/18, 19:34

  3. Markus Klein commented on patch set 1 V 0 03/19/18, 19:36

    will do some more checks
  4. Markus Klein commented on patch set 1 V +1 03/19/18, 19:40

    This function is actually really unfortunate. The result is actually not the return value, but ALSO the side-effect of $this->rootLine being modified. Oh dear.
  5. Benni Mack commented on patch set 1 V +2 CR +2 03/19/18, 20:17

    totally fine
  6. Benni Mack merged patch set 2 04/09/18, 07:13