56377[BUGFIX] Finishers with output must return the output
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Wouter Wolters +1
- Stefan Froemken +1
- Manuel Selbach +1
- Richard Haeser +1
-
Verified V +2
- Stefan Neufeind +2
- Stefan Froemken +1
- Manuel Selbach +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2127
Show 12 earlier messages
-
Ralf Zimmermann uploaded patch set 1 03/20/18, 11:29
-
TYPO3com voted on patch set 1 V +1 03/20/18, 11:37 Completed build in 07m 55s on Tue, 20 Mar, 12:37 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21711
-
Georg Ringer commented on patch set 1 CR -1 03/20/18, 11:38
we dont do followups anymore, every patch needs its own issue and bugfix/task commit msg -
Ralf Zimmermann updated the commit message in patch set 2 03/20/18, 11:38
-
TYPO3com voted on patch set 2 V +1 03/20/18, 11:48 Completed build in 09m 31s on Tue, 20 Mar, 12:48 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21714
-
Ralf Zimmermann rebased onto patch set 3 03/20/18, 19:34
-
TYPO3com voted on patch set 3 V +1 03/20/18, 19:43 Completed build in 08m 38s on Tue, 20 Mar, 08:43 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21720
-
Mathias Schreiber updated the commit message in patch set 4 03/22/18, 08:41
-
TYPO3com voted on patch set 4 V +1 03/22/18, 08:56 Completed build in 15m 01s on Thu, 22 Mar, 09:56 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21772
-
Jan Delius voted on patch set 4 V +1 03/23/18, 08:02
-
Jan Delius voted on patch set 4 CR +1 03/23/18, 08:25
-
Rico Drexler voted on patch set 4 V +1 03/23/18, 08:26
-
Manuel Selbach commented on patch set 4 04/04/18, 15:24
ConfirmationFinisher.php:94Could be removed as it is not used anymore. -
Joshua Westerheide voted on patch set 4 CR +1 04/06/18, 14:57
-
Riny van Tiggelen voted on patch set 4 V +1 CR +1 04/11/18, 12:44
-
Richard Haeser rebased onto patch set 5 04/11/18, 13:08
-
Richard Haeser uploaded patch set 6 04/11/18, 13:10
-
Richard Haeser voted on patch set 6 V +1 CR +1 04/11/18, 13:11
-
TYPO3com commented on patch set 5 04/11/18, 13:17 Completed build in 08m 53s on Wed, 11 Apr, 03:17 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22268
-
TYPO3com voted on patch set 6 V +1 04/11/18, 13:19 Completed build in 09m 13s on Wed, 11 Apr, 03:19 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22269
-
Stefan Neufeind voted on patch set 6 CR +1 04/11/18, 13:41
-
Manuel Selbach voted on patch set 6 V +1 CR +1 04/11/18, 20:02
-
Stefan Froemken commented on patch set 6 V +1 CR +1 04/12/18, 11:39
I have tested it with multiple ConfirmationFinishers. Content was perfectly added one after the other. In some cases I have added another Finisher in between no problem. So IMO it's ready to merge. -
Wouter Wolters voted on patch set 6 CR +1 04/14/18, 13:29
-
Stefan Neufeind voted on patch set 6 V +2 CR +2 04/15/18, 08:29
-
Stefan Neufeind merged patch set 7 04/15/18, 08:29
-
Frank Nägler commented on patch set 7 04/30/18, 15:53
post -1 because of a regression in v8: https://forge.typo3.org/issues/84901