Review main Merged

56377[BUGFIX] Finishers with output must return the output

Ralf Zimmermann CR +2 V +2 Easy +19 −8 updated 04/30/18, 15:53

Commit message

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Now, finishers with output can return this as string instead of setting
this directly into the response (which results in a double output).

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Stefan Froemken +1
    • Manuel Selbach +1
    • Richard Haeser +1
  • Verified V +2
    • Stefan Neufeind +2
    • Stefan Froemken +1
    • Manuel Selbach +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2127

Show 12 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 03/20/18, 11:29

  2. TYPO3com voted on patch set 1 V +1 03/20/18, 11:37 Completed build in 07m 55s on Tue, 20 Mar, 12:37 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21711

  1. Georg Ringer commented on patch set 1 CR -1 03/20/18, 11:38

    we dont do followups anymore, every patch needs its own issue and bugfix/task commit msg
  2. Ralf Zimmermann updated the commit message in patch set 2 03/20/18, 11:38

  3. TYPO3com voted on patch set 2 V +1 03/20/18, 11:48 Completed build in 09m 31s on Tue, 20 Mar, 12:48 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21714

  4. Ralf Zimmermann rebased onto patch set 3 03/20/18, 19:34

  5. TYPO3com voted on patch set 3 V +1 03/20/18, 19:43 Completed build in 08m 38s on Tue, 20 Mar, 08:43 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21720

  6. Mathias Schreiber updated the commit message in patch set 4 03/22/18, 08:41

  7. TYPO3com voted on patch set 4 V +1 03/22/18, 08:56 Completed build in 15m 01s on Thu, 22 Mar, 09:56 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21772

  8. Jan Delius voted on patch set 4 V +1 03/23/18, 08:02

  9. Jan Delius voted on patch set 4 CR +1 03/23/18, 08:25

  10. Rico Drexler voted on patch set 4 V +1 03/23/18, 08:26

  11. Manuel Selbach commented on patch set 4 04/04/18, 15:24

    ConfirmationFinisher.php:94

    Could be removed as it is not used anymore.
  12. Joshua Westerheide voted on patch set 4 CR +1 04/06/18, 14:57

  13. Riny van Tiggelen voted on patch set 4 V +1 CR +1 04/11/18, 12:44

  14. Richard Haeser rebased onto patch set 5 04/11/18, 13:08

  15. Richard Haeser uploaded patch set 6 04/11/18, 13:10

  16. Richard Haeser voted on patch set 6 V +1 CR +1 04/11/18, 13:11

  17. TYPO3com commented on patch set 5 04/11/18, 13:17 Completed build in 08m 53s on Wed, 11 Apr, 03:17 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22268

  18. TYPO3com voted on patch set 6 V +1 04/11/18, 13:19 Completed build in 09m 13s on Wed, 11 Apr, 03:19 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22269

  19. Stefan Neufeind voted on patch set 6 CR +1 04/11/18, 13:41

  20. Manuel Selbach voted on patch set 6 V +1 CR +1 04/11/18, 20:02

  21. Stefan Froemken commented on patch set 6 V +1 CR +1 04/12/18, 11:39

    I have tested it with multiple ConfirmationFinishers. Content was perfectly added one after the other. In some cases I have added another Finisher in between no problem. So IMO it's ready to merge.
  22. Wouter Wolters voted on patch set 6 CR +1 04/14/18, 13:29

  23. Stefan Neufeind voted on patch set 6 V +2 CR +2 04/15/18, 08:29

  24. Stefan Neufeind merged patch set 7 04/15/18, 08:29

  25. Frank Nägler commented on patch set 7 04/30/18, 15:53

    post -1 because of a regression in v8: https://forge.typo3.org/issues/84901