Review main Merged

56378[BUGFIX] Do not deprecate RsaEncryptionEncoder::getRsaPublicKey()

Mathias Brodala CR +2 V +2 Easy +23 −20 updated 03/20/18, 12:55

Commit message

Also use this API in the RSA public key controller to avoid code
duplication.

Review

  • Code review CR +2
    • Benni Mack +2
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Mathias Brodala uploaded patch set 1 03/20/18, 11:35

  2. TYPO3com voted on patch set 1 V -1 03/20/18, 11:35 Completed build in 10s on Tue, 20 Mar, 12:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21712

  3. Mathias Brodala uploaded patch set 2 03/20/18, 11:36

  4. TYPO3com voted on patch set 2 V +1 03/20/18, 11:45 Completed build in 09m 16s on Tue, 20 Mar, 12:46 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21713

  5. Nicole Hummel commented on patch set 3 03/20/18, 11:52

    Published edit on patch set 2.
  6. Nicole Hummel voted on patch set 3 V +1 CR +1 03/20/18, 11:53

  7. Mathias Brodala commented on patch set 3 03/20/18, 11:53

    RsaPublicKeyGenerationController.php:37

    I intentionally did not do this since we won't ever add unit tests for controllers.
  8. TYPO3com voted on patch set 3 V +1 03/20/18, 12:00 Completed build in 08m 22s on Tue, 20 Mar, 01:00 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21715

  9. Benni Mack voted on patch set 3 V +2 CR +2 03/20/18, 12:55

  10. Benni Mack merged patch set 4 03/20/18, 12:55