56380[BUGFIX] Change the order of the AJAX Request for image cropping
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Giuseppe Cavallaro uploaded patch set 1 03/20/18, 12:48
-
TYPO3com voted on patch set 1 V +1 03/20/18, 12:56 Completed build in 08m 20s on Tue, 20 Mar, 01:56 PM Test Summary: 58219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2152
-
Markus Klein commented on patch set 1 CR -1 03/20/18, 21:46
Thanks for your contribution Giuseppe! I added two comments, but didn't read your JS change yet. Please push the patch for the master branch first as noted in our contribution guidelines. Backports for older versions will be taken care of by the core team. https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/WorkflowExplained/Index.html#typo3-contribution-workflow Thanks!Please adjust the commit message to conform with our guidelines in chosen time form, language and formatting. https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/CommitMessage.htmlA patch shall always be for master (the current version) and if necessary for stable released versions. (unless a bug needs an explicit independent fix for a released version) -
Alexander Schnitzler commented on patch set 1 V +1 CR -1 03/28/18, 09:52
I can confirm that the patch fixes the issue in 8.7.12. Can you please push the patch to master, so we can merge this quickly and a fix makes it into 8.7.13? -
Giuseppe Cavallaro commented on patch set 1 03/28/18, 11:44
> Patch Set 1: Code-Review-1 > > (2 comments) > > Thanks for your contribution Giuseppe! > > I added two comments, but didn't read your JS change yet. > Please push the patch for the master branch first as noted in our contribution guidelines. Backports for older versions will be taken care of by the core team. > > https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/WorkflowExplained/Index.html#typo3-contribution-workflow > > Thanks! Hello Markus, in the master branch there are only minified JS Files and TypeScript Files. I dont have any experience with TypeScript or any environment for it. So sadly I cannot patch it there. -
Frank Nägler commented on patch set 1 CR -1 03/28/18, 12:00
I will update the patch in some minutes -
Frank Nägler abandoned the change 03/28/18, 12:36
abandon this one, after review of the master version, this can be backported with reegular process. -
Christian Kuhn restored the change 03/29/18, 13:04
-
Frank Nägler uploaded patch set 2 03/29/18, 13:04
-
Christian Kuhn voted on patch set 2 V +1 CR +1 03/29/18, 13:07
-
TYPO3com voted on patch set 2 V +1 03/29/18, 13:18 Completed build in 13m 15s on Thu, 29 Mar, 03:18 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2198
-
Frank Nägler voted on patch set 2 V +2 CR +2 03/29/18, 13:35
-
Frank Nägler merged patch set 3 03/29/18, 13:35