Review TYPO3_8-7 Abandoned

56389Revert "[BUGFIX] Trigger submit of RSA encrypted form properly"

Oliver Hader CR 0 V 0 Easy +2 −2 updated 03/21/18, 10:28

Commit message

This reverts commit 8bcd58a219d49340de79e92bdeed69c0cf2e6eec.

Since the initial change for issue #76120 addressed the backend part
as well - which would not have been required, since the mentioned issue
was about the frontend behavior only, the change that has been reverted
now again has been considered as superfluous work-around.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 03/21/18, 09:30

  2. TYPO3com voted on patch set 1 V +1 03/21/18, 09:38 Completed build in 08m 06s on Wed, 21 Mar, 10:38 AM Test Summary: 58219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2154

  3. Kevin Ditscheid commented on patch set 1 03/21/18, 09:38

    Why the revert? Is there something wrong with this change? The login issue with Firefox needs to be fixed asap
  4. Oliver Hader updated the commit message in patch set 2 03/21/18, 09:41

  5. TYPO3com voted on patch set 2 V +1 03/21/18, 09:49 Completed build in 08m 29s on Wed, 21 Mar, 10:49 AM Test Summary: 58219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2155

  6. Oliver Hader updated the commit message in patch set 3 03/21/18, 09:51

  7. Andreas Kienast commented on patch set 3 03/21/18, 09:54

    > Patch Set 1: > > Why the revert? Is there something wrong with this change? The login issue with Firefox needs to be fixed asap That's why it gets reverted, to fix the issue *properly*.
  8. Oliver Hader commented on patch set 3 03/21/18, 09:55

    Please read the core team channel and the description provided in issue #84503
  9. Kevin Ditscheid commented on patch set 3 03/21/18, 10:02

    > > Patch Set 1: > > > > Why the revert? Is there something wrong with this change? The > login issue with Firefox needs to be fixed asap > > That's why it gets reverted, to fix the issue *properly*. All good now, the first Patch set didn't contain any information about affected ticket ids, nor did it contain a description, but Oliver fixed the commit message shortly after
  10. TYPO3com voted on patch set 3 V +1 03/21/18, 10:06 Completed build in 14m 15s on Wed, 21 Mar, 11:06 AM Test Summary: 58219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2156

  11. Oliver Hader voted on patch set 3 V +2 CR +2 03/21/18, 10:21

  12. Oliver Hader updated the commit message in patch set 4 03/21/18, 10:22

  13. Oliver Hader abandoned the change 03/21/18, 10:28

    Gerrit has a strange behavior when using the UI to revert changes...