Review main Merged

5640[BUGFIX] EM: Available extension list misses icons

Steffen Gebert CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The list of available extensions misses the install/uninstall icons in
Firefox 7 and Internet Explorer 9.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1
  • Verified V +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 9

  1. Xavier Perseguers commented on patch set 1 1 comment 10/09/11, 13:34

    I would prefer that you didn't submit this
  2. Xavier Perseguers commented on patch set 2 10/09/11, 13:34

    Verified; Looks good to me, but someone else must approve
  3. Steffen Gebert uploaded patch set 2 10/09/11, 13:34

  4. Steffen Gebert commented on patch set 2 10/09/11, 13:34

    Indeed - verified also with IE9
  5. Jigal van Hemert commented on patch set 1 10/09/11, 13:34

    I would prefer that you didn't submit this

    t3_em.css:227

    This looks not right :-)

    em_components.js:155

    Setting the width to 47 (without any changes to CSS) fixed the problem in FF7/IE9 and didn't cause problems in other browsers.
  6. Jigal van Hemert commented on patch set 2 V 0 10/09/11, 13:34

    by team member; Looks good to me, approved Works now in IE9, FF7, Chrome, Opera, Safari (on Windows Vista).
  7. Mr. Jenkins commented on patch set 1 10/09/11, 13:34

  8. Mr. Jenkins commented on patch set 2 10/09/11, 13:34

  9. Jigal van Hemert merged patch set 2 10/09/11, 13:34