5641[BUGFIX] Race-condition while updating extension list
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Markus Klein +1
- Kay Strobach +1
- Dmitry Dulepov +1
-
Verified V +2
- Xavier Perseguers +2
- Markus Klein +1
- Dmitry Dulepov +1
Issues 1
Files 1
Review log 16
-
Dmitry Dulepov commented on patch set 1 10/10/11, 20:31
I think the change is good enough to be submitted. So you do not have to give -1 to your own patch :) -
Dmitry Dulepov commented on patch set 1 10/10/11, 20:31
Verified; Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 1 10/10/11, 20:31
The only thing that bothers me, is that the timeout is not reset back. So the value will stay large. This may cause many requests running from the browser (for example, login check requests when the server is down). -
Markus Klein commented on patch set 1 10/10/11, 20:31
Verified; Looks good to me, but someone else must approve Thanks so much for this Steffen! -
Xavier Perseguers commented on patch set 1 V 0 10/10/11, 20:31
by team member; Looks good to me, approved -
Steffen Gebert commented on patch set 1 10/10/11, 20:31
Please don't overcomplicate this! There's already a bug report for the case, when the max_execution_time is reached. But this would be a bigger change. Problem is that setting back has to be somewhere inside the callback of TYPO3.EM.ExtDirect.repositoryUpdate() I think. As the Ajax call is it would be reset immediately, otherwise. The "big brother" of this problem is #26993, which has even worse effects. -
Steffen Gebert commented on patch set 1 10/10/11, 20:31
I would prefer that you didn't submit this Yes, of course, I know. But I was not able to do that. So this is still a solution, which I consider as not final. However I think that the relogin runs in another frame and the change only affects the EM. -
Steffen Gebert commented on patch set 1 10/10/11, 20:31
BTW: I don't know, if this is the best/cleanest solution! Would be good, if sb. with ExtJS knowledge could have a look at it! -
Steffen Gebert commented on patch set 1 10/10/11, 20:31
I would say, it depends on the use case. When doing modifying operations, which might take a long time, we must increase the timeout. In case of displaying lists etc., it's IMHO fine to resend the request, in case of the first one was dropped by the server. But well, I would have no problem with disabling this functionality (as there's no guarantee that the second one succeeds). -
Steffen Gebert commented on patch set 1 10/10/11, 20:31
No score fine. can still be improved further, but in principle it's okay, I'd say. -
Kay Strobach commented on patch set 1 10/10/11, 20:31
Looks good to me, but someone else must approve extjs code is ok for using extdirect - but after the request the timeout should be set back to the default value ;) Additionally this doesn't solve the problem with slow internet connections. And we need to set the max execution time inside the request to the same value as in the extdirect code! Or you will get a: Fatal error: Maximum execution time of 300 seconds exceeded in t3lib/class.t3lib_db.php on line 146 Perhaps the update can be split into different requests: - fetch file (dispaly progress to user)(perhaps splittet http request ....) - parse file and update db (dispaly progress to user) Thanks Kay -
Kay Strobach commented on patch set 1 10/10/11, 20:31
but wouldn't it be better to set the timeout to e.g. maxExectime+20secs globally - otherwise we may encouter this problem at many places with long operations :( -
Kay Strobach commented on patch set 1 10/10/11, 20:31
the same problem can occur on sending an extension to TER with slow internet connections :( -
Kay Strobach commented on patch set 1 10/10/11, 20:31
resend is ok for me - but the timeout should be set globally to make debugging easier ;) different settings can be a big problem with timely overlapping ajax requests ;) -
Mr. Jenkins commented on patch set 1 10/10/11, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2059/ : SUCCESS -
Steffen Gebert merged patch set 1 10/10/11, 20:31