Review main Merged

56413[FEATURE] Use dynamic path for typo3temp/var/

Benni Mack CR +2 V +2 Hard +205 −112 updated 06/12/21, 18:41

Commit message

All TYPO3 Core areas where typo3temp/var/ was directly used,
the new Environment::getVarPath() API is now used.

When running via composer or setting the environment
variable "TYPO3_PATH_APP", the folder is $projectRootPath . /var
otherwise "typo3temp/var/" as before.

Additional changes to the default naming scheme
- Cache folders are now named lower-case (Cache/Code becomes
cache/code). 
- Install tool session files are stored within "var/session" instead of
"var/InstallToolSessions".
- Extension Manager files are now within "var/extensionmanager"
in a lower-cased variant
- log files are now placed into "var/log" instead of "var/logs"
- lock files are now placed into "var/lock" instead of "var/locks"

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2028

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 03/21/18, 19:07

  2. TYPO3com voted on patch set 1 V +1 03/21/18, 19:17 Completed build in 09m 43s on Wed, 21 Mar, 08:17 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21755

  3. Benni Mack commented on patch set 2 03/21/18, 22:10

    Published edit on patch set 1.
  1. TYPO3com voted on patch set 2 V -1 03/21/18, 22:18 Completed build in 08m 13s on Wed, 21 Mar, 11:18 PM Test Summary: 1 of 31028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21768

  2. Benni Mack uploaded patch set 3 03/28/18, 06:43

  3. Benni Mack updated the commit message in patch set 4 03/28/18, 06:44

  4. TYPO3com voted on patch set 3 V +1 03/28/18, 06:52 Completed build in 08m 46s on Wed, 28 Mar, 08:52 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21819

  5. TYPO3com voted on patch set 4 V +1 03/28/18, 06:54 Completed build in 10m 25s on Wed, 28 Mar, 08:54 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21820

  6. Georg Ringer commented on patch set 4 03/28/18, 07:09

    Feature-84545-AllowTemporaryFilesToBeStoredOutsideTheDocumentRoot.rst:21

    would just state "not publicly accessible anymore". there is more than browsers...

    Feature-84545-AllowTemporaryFilesToBeStoredOutsideTheDocumentRoot.rst:35

    if

    Feature-84545-AllowTemporaryFilesToBeStoredOutsideTheDocumentRoot.rst:51

    for what?
  7. Mathias Brodala commented on patch set 4 03/28/18, 07:35

    Feature-84545-AllowTemporaryFilesToBeStoredOutsideTheDocumentRoot.rst:16

    If you update this file, please also add :file:`path/to/file` to highlight file paths. :-)
  8. Susi Moog commented on patch set 4 CR -1 03/28/18, 07:39

    on it.
  9. Susi Moog uploaded patch set 5 03/28/18, 08:26

  10. TYPO3com voted on patch set 5 V +1 03/28/18, 08:34 Completed build in 08m 02s on Wed, 28 Mar, 10:34 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21821

  11. Georg Ringer voted on patch set 5 V +1 CR +1 03/28/18, 10:14

  12. Benni Mack uploaded patch set 6 03/28/18, 15:58

  13. TYPO3com voted on patch set 6 V +1 03/28/18, 16:07 Completed build in 08m 21s on Wed, 28 Mar, 06:07 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21836

  14. Benni Mack commented on patch set 7 03/28/18, 16:21

    Published edit on patch set 6.
  15. TYPO3com voted on patch set 7 V +1 03/28/18, 16:29 Completed build in 07m 58s on Wed, 28 Mar, 06:29 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21837

  16. Susi Moog voted on patch set 7 CR +1 03/28/18, 16:57

  17. Georg Ringer voted on patch set 7 V +1 CR +1 03/28/18, 17:07

  18. Benni Mack updated the commit message in patch set 8 03/28/18, 18:35

  19. TYPO3com voted on patch set 8 V +1 03/28/18, 18:45 Completed build in 09m 12s on Wed, 28 Mar, 08:45 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21838

  20. Georg Ringer voted on patch set 8 V +1 CR +1 03/29/18, 03:47

  21. Susi Moog voted on patch set 8 V +2 CR +2 03/29/18, 09:23

  22. Susi Moog merged patch set 9 03/29/18, 09:23

  23. Markus Klein commented on patch set 9 04/10/18, 14:47

    InstallStatusReport.php:80

    regression here, fixed with https://review.typo3.org/56625
  24. Frans Saris commented on patch set 9 04/08/21, 15:25

    AbstractOnlineMediaHelper.php:122 Unresolved

    This file should be kept in a public folder see https://forge.typo3.org/issues/93860
  25. Benni Mack commented on patch set 9 06/12/21, 18:41