Review main Merged

56415[FEATURE] Make csv delimiter configurable

Guido Schmechel CR +2 V +2 Easy +27 −1 updated 03/29/18, 12:09

Commit message

It is now possible to control the delimiter and quote character of the
recordlist csv export.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Patricia Tiedemann +1
    • Kevin Appelt +1
    • Frank Nägler +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1720

  1. Guido Schmechel uploaded patch set 1 03/21/18, 20:36

  2. TYPO3com voted on patch set 1 V +1 03/21/18, 20:44 Completed build in 07m 47s on Wed, 21 Mar, 09:44 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21764

  3. Georg Ringer commented on patch set 1 CR -1 03/22/18, 07:00

    Feature-84517-Recordlist-MakeCsvDelimiterConfigurable.rst:12

    i guess this is Page TsConfig? should be added
  4. Guido Schmechel uploaded patch set 2 03/22/18, 21:14

  5. TYPO3com voted on patch set 2 V +1 03/22/18, 21:22 Completed build in 08m 09s on Thu, 22 Mar, 10:22 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21788

  6. Nicole Hummel commented on patch set 2 03/24/18, 18:44

    In general I have to admit I'm against any configuration here and stick to one defined one. I don't understand why one would need to change the defaults.

    Feature-84517-Recordlist-MakeCsvDelimiterConfigurable.rst:12

    were

    Feature-84517-Recordlist-MakeCsvDelimiterConfigurable.rst:14

    ,
  7. Guido Schmechel commented on patch set 2 03/24/18, 22:18

    Hi Nicole, i understand your concerns. My case: The customer wants to export data in the backend and simply open the file in Excel with a double-click. But if there is a comma, the list will not be displayed correctly. Now you have to import the content and manage it with several clicks. The customer would like to have that easier and that would be the option for us in TYPO3 ;-) I hope you understand it :-)
  8. Guido Schmechel uploaded patch set 3 03/24/18, 22:33

  9. TYPO3com voted on patch set 3 V +1 03/24/18, 22:41 Completed build in 07m 55s on Sat, 24 Mar, 11:41 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21809

  10. Jörg Bösche voted on patch set 3 CR +1 03/26/18, 06:41

  11. Steffen Frese voted on patch set 3 CR +1 03/27/18, 12:11

  12. Jigal van Hemert commented on patch set 3 03/27/18, 19:30

    Agree with Nicole. I don't think we need more and more configuration. Excel uses the List separator that is configured in the Regional settings of the Control panel. Perhaps it's better to fix it at Excel's end?
  13. Guido Schmechel commented on patch set 3 03/28/18, 08:03

    I think this is not a problem because the unconfigured default case use the existing defaults: , and " You must only configure these values if you need it :-)
  14. Frank Nägler commented on patch set 3 V +1 CR +1 03/28/18, 14:22

    I am totally fine with the idea and the solution. CSV has no standard, so any combination of delimiter and quote character is valid. The default still works, and the new options make it possible to control the generated output in case you have different requirements. @Jigal: Yes excel can import it, but the default delimiter and quote character in excel are different to our defaults. If there is no plan to drop the crappy CSV format, this is a valid use-case and I opt to merge it.
  15. Jigal van Hemert commented on patch set 3 03/28/18, 18:37

    > @Jigal: Yes excel can import it, but the default delimiter and > quote character in excel are different to our defaults. @Frank: I tried to explain that Excel doesn't have a different default, but its standard settings let it use the List Separator character that is configured in Windows. In some languages apparently a semicolon is configured by default. If in an organisation users have different regional settings the configuration in TYPO3 is useless.
  16. Jörg Bösche voted on patch set 3 V +1 03/28/18, 19:40

  17. Kevin Appelt commented on patch set 3 CR +1 03/28/18, 19:44

    This patch will resolve a lot of customer requests.
  18. Patricia Tiedemann voted on patch set 3 CR +1 03/28/18, 19:50

  19. Christian Kuhn commented on patch set 3 V +2 CR +2 03/29/18, 12:09

    I don't think these two additional options kill kitten. If these two options reduce headaches on client side, I think we should just do it.
  20. Christian Kuhn merged patch set 4 03/29/18, 12:09