Review main Merged

56416[BUGFIX] Allow PSR-7 Uris to allow no port at all

Benni Mack CR +2 V +2 Easy +21 −8 updated 03/22/18, 12:51

Commit message

In order to set a PSR-7 based uri to the default port
the specs allow to set $uri->withPort(null) but our
tests and implementation restrict that.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Mathias Schreiber +1
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Mathias Schreiber +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 03/21/18, 21:32

  2. Benni Mack uploaded patch set 2 03/21/18, 21:38

  3. TYPO3com voted on patch set 1 V +1 03/21/18, 21:40 Completed build in 08m 17s on Wed, 21 Mar, 10:40 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21765

  4. TYPO3com voted on patch set 2 V +1 03/21/18, 21:46 Completed build in 08m 11s on Wed, 21 Mar, 10:46 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21766

  5. Mathias Brodala commented on patch set 2 V +1 CR +1 03/22/18, 08:35

    Verified by Bamboo.
  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 03/22/18, 08:43

  7. Georg Ringer voted on patch set 2 V +2 CR +2 03/22/18, 12:51

  8. Georg Ringer merged patch set 3 03/22/18, 12:51

  9. Georg Ringer commented on patch set 3 03/22/18, 12:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 32ce84407bc03e143c6ba7435cf156945054f802