Review main Merged

56430[BUGFIX] Hide duplicate button if sys_file_meta is edited

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/29/18, 11:58

Commit message

Hide the button "duplicate" in the toolbar if meta data of
files is edited.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tobi Kretschmann +1
    • Guido Schmechel +1
    • Frank Nägler +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Tobi Kretschmann +1
    • Guido Schmechel +1
    • Riccardo De Contardi +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Georg Ringer uploaded patch set 1 03/22/18, 13:00

  2. TYPO3com voted on patch set 1 V +1 03/22/18, 13:10 Completed build in 10m 08s on Thu, 22 Mar, 02:10 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21779

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 03/22/18, 22:00

  4. Riccardo De Contardi voted on patch set 1 V +1 03/23/18, 22:40

  5. Jörg Bösche voted on patch set 1 V +1 CR +1 03/26/18, 06:47

  6. Andreas Kienast commented on patch set 1 03/26/18, 07:40

    EditDocumentController.php:1482

    Does it make sense to bind this to the `saveDocNew` setting in TS.
  7. Tobi Kretschmann voted on patch set 1 V +1 CR +1 03/26/18, 09:10

  8. Tymoteusz Motylewski commented on patch set 1 03/29/18, 10:19

    EditDocumentController.php:1482 Reply Unresolved

    what do you mean?
  9. Christian Kuhn commented on patch set 1 V +1 CR +1 03/29/18, 11:56

    not a *that* huge fan of the hardcoded exception here (maybe this should be a TCA / TS setting?), but good to go for the time being, i'd say.
  10. Frank Nägler voted on patch set 1 CR +1 03/29/18, 11:58

  11. Christian Kuhn voted on patch set 1 V +2 CR +2 03/29/18, 11:58

  12. Christian Kuhn merged patch set 2 03/29/18, 11:58