56431[BUGFIX] Remove attribute 'selected' if its value is false
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Timo Poppinga +1
- Oliver Hader +1
- Daniel Goerz +1
-
Verified V +2
- Anja Leichsenring +2
- Timo Poppinga +1
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 4353
Show 2228 earlier messages
-
Georg Ringer uploaded patch set 1 03/22/18, 13:35
-
Mathias Brodala commented on patch set 1 03/22/18, 13:43
-
TYPO3com voted on patch set 1 V +1 03/22/18, 13:43 Completed build in 08m 09s on Thu, 22 Mar, 02:43 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21781
-
Mathias Schreiber commented on patch set 1 CR -1 05/10/18, 15:03
blocking for the time being. Let's wait for Claus' feedback on the matterOptionViewHelper.php:58Replygot in touch with Claus over this one -
Claus Due commented on patch set 1 07/17/18, 08:32
OptionViewHelper.php:58ReplyThe problem here sort of is the implementation: "selected" is registered as a tag attribute but is not really handled as a tag attribute and has a data type that's not normal for tag attributes. When used correctly, tag attributes are strings or string-compatible values. They should be somewhat transparent: either you define the value in the template and that's the value that gets used - or you define another argument and it results in an attribute being added. I see two correct solutions: 1. Do not declare "selected" as a tag attribute, rather as a standard VH argument. Check it the same way, but rather than removing the attribute, just avoid adding it if the value is falsy. Or, 2. Declare this as a string tag attribute and expect people to pass `selected` as string value if they want the property to be handled, then call ->ignoreEmptyAttrubutes() on the TagBuilder so it doesn't write the attribute if empty. The first one may be the less destructive one. The second is the more transparent/obvious/XHTML-like but it's probably a breaking change. Ignoring empty attributes is only possible to do for all attributes on a tag, not individually. I'd not put any of this in Fluid though - it definitely seems like a task for the VH and generally is a pointer that we should do something about our cases where we define VH arguments that are tag attributes and are not string-or-int typed. I'd suggest using the first option above. -
Claus Due commented on patch set 1 07/17/18, 08:35
Apologies - I had that comment saved as draft since I guess March or April. Just forgot to actually post it... -
Mathias Brodala commented on patch set 2 07/17/18, 08:55
Published edit on patch set 1. -
Mathias Brodala commented on patch set 2 07/17/18, 08:55
Thanks for the confirmation, that's what I had in mind too. -
TYPO3com voted on patch set 2 V +1 07/17/18, 09:02 Completed build in 07m 29s on Tue, 17 Jul, 11:02 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25494
-
Claus Due commented on patch set 3 07/17/18, 09:12
Published edit on patch set 2. -
Claus Due commented on patch set 3 CR +1 07/17/18, 09:13
Gave the argument default value to ensure it is always boolean type, never null. Doesn't this look so much simpler and cleaner?! I think so :) -
TYPO3com voted on patch set 3 V +1 07/17/18, 09:21 Completed build in 08m 42s on Tue, 17 Jul, 11:21 AM Test Summary: 33312 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25497
-
Mathias Brodala commented on patch set 3 07/17/18, 09:22
> Gave the argument default value to ensure it is always boolean > type, never null. Missed that, thanks. > Doesn't this look so much simpler and cleaner?! I think so :) I agree. ;-) -
Mathias Brodala voted on patch set 3 CR +1 07/17/18, 09:22
-
Wouter Wolters voted on patch set 3 CR +1 07/18/18, 19:46
-
Torben Hansen voted on patch set 3 CR +1 07/19/18, 03:35
-
Daniel Goerz voted on patch set 3 V +1 CR +1 07/19/18, 13:36
-
Andreas Kienast voted on patch set 3 CR +1 07/19/18, 13:48
-
Josef Glatz voted on patch set 3 V +1 CR +1 07/19/18, 15:24
-
Mathias Schreiber voted on patch set 3 V +1 CR +1 07/19/18, 15:37
-
Timo Poppinga commented on patch set 3 V -1 CR -1 07/19/18, 21:46
hi, in description you said: If set, overrides automatic detection of selected state for this option. this statmend is right if you set selected to true in the case of setting selected to false it do not overrides the automatic detection for me the right way ist to allow null again. Than we have three stats 1. null = automatic detection 2. false = no selcetion attribut at all 3. true = allways set the selected argumend -
Timo Poppinga uploaded patch set 4 07/19/18, 22:13
-
Timo Poppinga uploaded patch set 5 07/19/18, 22:15
-
TYPO3com voted on patch set 4 V +1 07/19/18, 22:21 Completed build in 08m 12s on Fri, 20 Jul, 12:21 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25588
-
TYPO3com voted on patch set 5 V +1 07/19/18, 22:28 Completed build in 12m 41s on Fri, 20 Jul, 12:28 AM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25589
-
Daniel Goerz uploaded patch set 6 07/20/18, 09:30
-
Daniel Goerz commented on patch set 6 07/20/18, 09:30
I got the feeling we might need unittests here :) -
TYPO3com voted on patch set 6 V +1 07/20/18, 09:43 Completed build in 12m 31s on Fri, 20 Jul, 11:43 AM Test Summary: 33469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25604
-
Andreas Kienast uploaded patch set 7 07/20/18, 13:24
-
Andreas Kienast uploaded patch set 8 07/20/18, 14:14
-
Andreas Kienast commented on patch set 8 07/20/18, 14:16
OptionViewHelperTest.php:33UnresolvedBeware: Remove when backporting to v8! -
TYPO3com voted on patch set 8 V +1 07/20/18, 15:16 Completed build in 1h 28m 20s on Fri, 20 Jul, 05:16 PM Test Summary: 33469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25613
-
TYPO3com voted on patch set 7 V +1 07/20/18, 15:27 Completed build in 4h 02m 31s on Fri, 20 Jul, 05:27 PM Test Summary: 33469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25612
-
Andreas Kienast voted on patch set 8 V +1 CR +1 07/27/18, 13:36
-
Timo Poppinga voted on patch set 8 V +1 CR +1 07/27/18, 13:47
-
Josef Glatz voted on patch set 8 CR +1 07/29/18, 18:15
-
Daniel Goerz voted on patch set 8 V +1 CR +1 07/29/18, 18:17
-
Josef Glatz voted on patch set 8 V +1 07/29/18, 18:20
-
Łukasz Uznański voted on patch set 8 CR +1 08/03/18, 12:17
-
Claus Due commented on patch set 9 08/03/18, 12:44
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V -1 08/03/18, 12:44 Completed build in 09s on Fri, 3 Aug, 02:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26080
-
Claus Due commented on patch set 9 08/03/18, 12:44
Switched condition expression to null coalesce -
Claus Due commented on patch set 10 08/03/18, 12:45
Published edit on patch set 9. -
TYPO3com voted on patch set 10 V +1 08/03/18, 12:52 Completed build in 07m 06s on Fri, 3 Aug, 02:52 PM Test Summary: 33669 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26081
-
Daniel Goerz voted on patch set 10 V +1 CR +1 08/03/18, 15:16
-
Timo Poppinga commented on patch set 10 V +1 CR +1 08/04/18, 08:49
nice code -
Anja Leichsenring voted on patch set 10 V +2 CR +2 08/05/18, 09:49
-
Anja Leichsenring merged patch set 11 08/05/18, 09:49
-
Oliver Hader commented on patch set 11 08/07/18, 12:13
BACKPORT missing - or did I overlook something? -
Mathias Brodala commented on patch set 11 08/07/18, 12:16
> BACKPORT missing - or did I overlook something? It's WIP: https://review.typo3.org/57814 -
Oliver Hader commented on patch set 11 08/20/18, 20:47
OptionViewHelper.php:53I lost track on the `removeAttribute` call - is it missing, not required or solved in some abstract class? -
Daniel Goerz commented on patch set 11 08/20/18, 21:04
OptionViewHelper.php:53ReplyIt is no longer registered as attribute but as argument instead. so we dont need to remove it but only add it if the conditions are met. -
Oliver Hader voted on patch set 11 CR +1 08/20/18, 21:09
OptionViewHelper.php:58