56432[BUGFIX] Unify language handling within TranslationStatusController
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1214
-
Georg Ringer uploaded patch set 1 03/22/18, 13:47
-
TYPO3com voted on patch set 1 V +1 03/22/18, 13:57 Completed build in 09m 28s on Thu, 22 Mar, 02:57 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21782
-
Daniel Haupt voted on patch set 1 CR +1 04/04/18, 15:25
-
Benni Mack commented on patch set 1 04/26/18, 05:35
In various other places (page/list module) there is a check on - if admin: show hidden languages - if non-admin: do not show hidden languages and only the ones selected (if specified)TranslationStatusController.php:364now this does not include hidden records anymore, correct? -
Markus Klein commented on patch set 1 04/26/18, 08:25
doesn't this break \TYPO3\CMS\Frontend\Controller\TranslationStatusController::renderL10nTable -
Mathias Schreiber commented on patch set 1 V +1 CR +1 05/10/18, 11:48
TranslationStatusController.php:364Replywhich is the intention of the patch, yes :) -
Massimiliano Fani voted on patch set 1 CR +1 05/10/18, 15:20
-
Christian Kuhn commented on patch set 1 05/10/18, 15:39
Stations? -
Georg Ringer updated the commit message in patch set 2 05/10/18, 17:52
-
TYPO3com voted on patch set 2 V +1 05/10/18, 18:02 Completed build in 09m 25s on Thu, 10 May, 08:02 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23283
-
Benni Mack voted on patch set 2 V +1 CR +1 05/10/18, 18:07
-
Andreas Kienast commented on patch set 2 CR -1 05/10/18, 18:12
on it -
Andreas Kienast voted on patch set 2 V +2 CR +2 05/10/18, 18:15
-
Andreas Kienast merged patch set 3 05/10/18, 18:15