Review main Abandoned

56437[WIP][FEATURE] Allow filling the Icon store with pre-rendered icons

Andreas Kienast CR 0 V 0 Normal +89 −12 updated 04/18/18, 08:04

Commit message

The Icons module is now able to receive a set of pre-rendered icons
(e.g. by the IconViewHelper). To achieve this, a special DOM node
(a so-called "icon space") must be created that contains the icons. That
DOM node must be passed to `Icon.findAllInIconSpace()`, any icon is then
directly stored in the internal cache.

After the processing is done, the icon space gets removed as it's not
required afterwards.

TODO:
- Check if it meets requirements for the Install Tool
- ReST

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 58

  1. Andreas Kienast uploaded patch set 1 03/22/18, 20:10

  2. TYPO3com voted on patch set 1 V +1 03/22/18, 20:20 Completed build in 09m 18s on Thu, 22 Mar, 09:20 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21785

  3. Andreas Kienast uploaded patch set 2 03/22/18, 20:22

  4. TYPO3com voted on patch set 2 V +1 03/22/18, 20:31 Completed build in 08m 21s on Thu, 22 Mar, 09:31 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21786

  5. Andreas Kienast uploaded patch set 3 03/22/18, 20:41

  6. TYPO3com voted on patch set 3 V +1 03/22/18, 20:50 Completed build in 08m 52s on Thu, 22 Mar, 09:50 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21787

  7. Frank Nägler commented on patch set 3 CR -1 04/03/18, 14:38

    let's use the UXW to find good solution for the problem
  8. Andreas Kienast abandoned the change 04/18/18, 08:04

    Will either go with promises or service workers