Review main Merged

56443[BUGFIX] Correctly deprecate globals usage in FormEngine

Nicole Hummel CR +2 V +2 Hard +293 −0 updated 03/30/18, 20:43

Commit message

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Stefan Neufeind +1
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2
    • Alexander Opitz +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1316

  1. Nicole Hummel uploaded patch set 1 03/24/18, 19:03

  2. TYPO3com voted on patch set 1 V -1 03/24/18, 19:12 Completed build in 08m 29s on Sat, 24 Mar, 08:12 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21807

  3. Markus Klein commented on patch set 1 03/24/18, 19:13

    DatabaseRowInitializeNew.php:152

    :array
  4. Nicole Hummel commented on patch set 1 03/24/18, 20:12

    DatabaseRowInitializeNew.php:152 Reply

    Still against mixing this up in one class ;-)
  5. Nicole Hummel uploaded patch set 2 03/24/18, 20:18

  6. TYPO3com voted on patch set 2 V +1 03/24/18, 20:26 Completed build in 08m 21s on Sat, 24 Mar, 09:26 PM Test Summary: 30896 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21808

  7. Markus Klein voted on patch set 2 CR +1 03/24/18, 20:39

  8. Jörg Bösche voted on patch set 2 CR +1 03/26/18, 06:42

  9. Mathias Brodala commented on patch set 3 03/26/18, 07:35

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 03/26/18, 07:44 Completed build in 09m 22s on Mon, 26 Mar, 09:44 AM Test Summary: 30896 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21810

  11. Jörg Bösche voted on patch set 3 CR +1 03/26/18, 07:56

  12. Tobi Kretschmann voted on patch set 3 CR +1 03/26/18, 08:52

  13. Steffen Frese voted on patch set 3 CR +1 03/27/18, 11:31

  14. Stefan Neufeind voted on patch set 3 V +1 CR +1 03/30/18, 12:17

  15. Alexander Opitz voted on patch set 3 V +2 CR +2 03/30/18, 20:43

  16. Alexander Opitz merged patch set 4 03/30/18, 20:43