56447[BUGFIX] Fix external page link in menu item
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Guido Schmechel +1
-
Verified V +2
- Stefan Neufeind +2
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1317
-
Cyril Janody uploaded patch set 1 03/26/18, 15:21
-
TYPO3com voted on patch set 1 V +1 03/26/18, 15:29 Completed build in 07m 46s on Mon, 26 Mar, 05:29 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2179
-
Guido Schmechel commented on patch set 1 03/26/18, 15:37
-
Wouter Wolters commented on patch set 1 CR -1 03/26/18, 16:08
Please push this patch first to master branch and keep the change-id the same. A core developer will take care of the backport. Thanks. -
Guido Schmechel commented on patch set 1 03/26/18, 16:18
Hi Wouter, master had an existing patch: https://review.typo3.org/c/54754/ See comment "Incompatible with 8.7". Because of that we want only push to 8.7 -
Cyril Janody commented on patch set 1 03/26/18, 17:02
Hi, I tried to push the fix but it creates a new branch .... I definitely do something wrong ... Need help :) Thks -
Cyril Janody uploaded patch set 2 03/26/18, 17:47
-
TYPO3com voted on patch set 2 V +1 03/26/18, 17:59 Completed build in 12m 46s on Mon, 26 Mar, 07:59 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2182
-
Wouter Wolters commented on patch set 2 03/26/18, 18:21
Ok if the patch is not needed in master anymore the Releases line must nog contain master but only 8.7 -
Cyril Janody updated the commit message in patch set 3 03/26/18, 19:00
-
TYPO3com voted on patch set 3 V +1 03/26/18, 19:08 Completed build in 08m 32s on Mon, 26 Mar, 09:08 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2183
-
Guido Schmechel commented on patch set 3 03/26/18, 20:29
Can you please give the commit message some love? See guidelines: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/CommitMessage.html -
Cyril Janody updated the commit message in patch set 4 03/26/18, 22:27
-
TYPO3com voted on patch set 4 V +1 03/26/18, 22:35 Completed build in 08m 22s on Tue, 27 Mar, 12:35 AM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2184
-
Guido Schmechel voted on patch set 4 V +1 CR +1 03/30/18, 09:52
-
Stefan Neufeind voted on patch set 4 V +2 CR +2 03/30/18, 12:14
-
Stefan Neufeind merged patch set 5 03/30/18, 12:14
AbstractMenuContentObject.php:1640Unresolved