Review TYPO3_8-7 Merged

56447[BUGFIX] Fix external page link in menu item

Cyril Janody CR +2 V +2 Easy +6 −2 updated 03/30/18, 12:14

Commit message

Set link target with config.extTarget if none has been specified.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Guido Schmechel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Cyril Janody uploaded patch set 1 03/26/18, 15:21

  2. TYPO3com voted on patch set 1 V +1 03/26/18, 15:29 Completed build in 07m 46s on Mon, 26 Mar, 05:29 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2179

  3. Guido Schmechel commented on patch set 1 03/26/18, 15:37

    AbstractMenuContentObject.php:1640 Unresolved

    Sorry. Unfortunately I see it only now.. Maybe move $tsfe over this condition and use this variable?
  4. Wouter Wolters commented on patch set 1 CR -1 03/26/18, 16:08

    Please push this patch first to master branch and keep the change-id the same. A core developer will take care of the backport. Thanks.
  5. Guido Schmechel commented on patch set 1 03/26/18, 16:18

    Hi Wouter, master had an existing patch: https://review.typo3.org/c/54754/ See comment "Incompatible with 8.7". Because of that we want only push to 8.7
  6. Cyril Janody commented on patch set 1 03/26/18, 17:02

    Hi, I tried to push the fix but it creates a new branch .... I definitely do something wrong ... Need help :) Thks
  7. Cyril Janody uploaded patch set 2 03/26/18, 17:47

  8. TYPO3com voted on patch set 2 V +1 03/26/18, 17:59 Completed build in 12m 46s on Mon, 26 Mar, 07:59 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2182

  9. Wouter Wolters commented on patch set 2 03/26/18, 18:21

    Ok if the patch is not needed in master anymore the Releases line must nog contain master but only 8.7
  10. Cyril Janody updated the commit message in patch set 3 03/26/18, 19:00

  11. TYPO3com voted on patch set 3 V +1 03/26/18, 19:08 Completed build in 08m 32s on Mon, 26 Mar, 09:08 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2183

  12. Guido Schmechel commented on patch set 3 03/26/18, 20:29

    Can you please give the commit message some love? See guidelines: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/CommitMessage.html
  13. Cyril Janody updated the commit message in patch set 4 03/26/18, 22:27

  14. TYPO3com voted on patch set 4 V +1 03/26/18, 22:35 Completed build in 08m 22s on Tue, 27 Mar, 12:35 AM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2184

  15. Guido Schmechel voted on patch set 4 V +1 CR +1 03/30/18, 09:52

  16. Stefan Neufeind voted on patch set 4 V +2 CR +2 03/30/18, 12:14

  17. Stefan Neufeind merged patch set 5 03/30/18, 12:14