Review main Merged

5646[BUGFIX] All fields of 'type'=>'group' are broken in IE

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The HTML multiple attribute is added for select boxes with size > 1 and
the Javascript to check this uses the multiple-property instead of the
getAttribute method which is poorly supported by various browsers.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Dmitry Dulepov +1
    • Steffen Gebert +1
  • Verified V +2
    • Jigal van Hemert +2
    • Dmitry Dulepov +1
    • Steffen Gebert +1

Files 1

Review log 7

  1. Dmitry Dulepov commented on patch set 2 10/10/11, 08:39

    Verified; Looks good to me, but someone else must approve Works in MSIE.
  2. Steffen Gebert commented on patch set 2 10/10/11, 08:39

    Verified; Looks good to me, but someone else must approve
  3. Jigal van Hemert commented on patch set 2 V 0 10/10/11, 08:39

    by team member; Looks good to me, approved Enough votes (both from Core Team members), so merged!
  4. Jigal van Hemert uploaded patch set 2 10/10/11, 08:39

  5. Mr. Jenkins commented on patch set 1 10/10/11, 08:39

  6. Mr. Jenkins commented on patch set 2 10/10/11, 08:39

  7. Jigal van Hemert merged patch set 2 10/10/11, 08:39