Review main Merged

56469[BUGFIX] Change the order of the AJAX Request for image cropping

Frank Nägler CR +2 V +2 Easy +22 −15 updated 03/29/18, 12:31

Commit message

It ensures that the request will not be overwritten by the spinning icon
on fast servers.

Before the changes, the image cropping tool triggered a Console Error
"Uncaught TypeError: Cannot read property 'cropArea' of undefined at
ImageManipulation.init (ImageManipulation.js)."

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1930

Show 45 earlier messages
  1. Frank Nägler uploaded patch set 1 03/28/18, 12:26

  2. Frank Nägler updated the commit message in patch set 2 03/28/18, 12:31

  3. Frank Nägler rebased onto patch set 3 03/28/18, 12:34

  4. TYPO3com voted on patch set 1 V +1 03/28/18, 12:36 Completed build in 09m 50s on Wed, 28 Mar, 02:36 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21824

  5. Frank Nägler uploaded patch set 4 03/28/18, 12:39

  1. TYPO3com voted on patch set 2 V +1 03/28/18, 12:42 Completed build in 11m 11s on Wed, 28 Mar, 02:42 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21825

  2. TYPO3com voted on patch set 3 V +1 03/28/18, 12:42 Completed build in 08m 49s on Wed, 28 Mar, 02:42 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21826

  3. TYPO3com voted on patch set 4 V +1 03/28/18, 12:47 Completed build in 08m 00s on Wed, 28 Mar, 02:47 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21827

  4. Frank Nägler uploaded patch set 5 03/28/18, 12:54

  5. Giuseppe Cavallaro commented on patch set 5 V +1 CR +1 03/28/18, 12:57

    This should do the trick.
  6. TYPO3com voted on patch set 5 V +1 03/28/18, 13:03 Completed build in 08m 47s on Wed, 28 Mar, 03:03 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21828

  7. Markus Klein updated the commit message in patch set 6 03/28/18, 13:18

  8. Markus Klein commented on patch set 6 CR +1 03/28/18, 13:18

    Fixed the commit msg
  9. TYPO3com voted on patch set 6 V -1 03/28/18, 13:27 Completed build in 08m 39s on Wed, 28 Mar, 03:27 PM Test Summary: 30820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21829

  10. TYPO3com voted on patch set 6 V +1 03/28/18, 13:29 Completed build in 19m 03s on Wed, 28 Mar, 03:29 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21829

  11. Andreas Kienast commented on patch set 6 CR -1 03/28/18, 18:19

    Modal.ts:345 Unresolved

    const

    Modal.ts:346

    I don't get the purpose of this completely. If this should avoid rendering the spinner icon twice, this condition should be around the Icons.getIcon() call, IMO.
  12. Andreas Kienast uploaded patch set 7 03/29/18, 08:46

  13. Andreas Kienast uploaded patch set 8 03/29/18, 08:46

  14. Andreas Kienast uploaded patch set 9 03/29/18, 08:49

  15. Giuseppe Cavallaro commented on patch set 9 03/29/18, 08:51

    Modal.ts:346 Reply Unresolved

    The spinner icon is not rendered twice. As you can see, there is another ajax call in line 353. In some cases, the second ajax call is finished loading first. When that happens, the content of the image cropper is replaced by the spinner. The fix prevent this behaviour.
  16. TYPO3com voted on patch set 7 V +1 03/29/18, 08:56 Completed build in 10m 30s on Thu, 29 Mar, 10:56 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21840

  17. TYPO3com voted on patch set 8 V +1 03/29/18, 08:58 Completed build in 12m 03s on Thu, 29 Mar, 10:58 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21841

  18. TYPO3com voted on patch set 9 V +1 03/29/18, 09:00 Completed build in 11m 35s on Thu, 29 Mar, 11:00 AM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21842

  19. Christian Kuhn uploaded patch set 10 03/29/18, 12:19

  20. Christian Kuhn commented on patch set 9 03/29/18, 12:20

    this is much better reproducible in page module on +content - depending on timing, the modal crashes on first load and shows no content. the adapted patch fixes this.
  21. Andreas Kienast voted on patch set 10 V +1 CR +1 03/29/18, 12:21

  22. Christian Kuhn voted on patch set 10 V +1 CR +1 03/29/18, 12:21

  23. TYPO3com voted on patch set 10 V +1 03/29/18, 12:29 Completed build in 09m 24s on Thu, 29 Mar, 02:29 PM Test Summary: 30891 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21849

  24. Frank Nägler voted on patch set 10 V +2 CR +2 03/29/18, 12:31

  25. Frank Nägler merged patch set 11 03/29/18, 12:31