56486[BUGFIX] Set opt-in for override checkbox in TCA input elements
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Stehlik +1
- Anja Leichsenring +1
- Frans Saris +1
-
Verified V +2
- Markus Klein +2
- Alexander Stehlik +1
- Anja Leichsenring +1
- Frans Saris +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+0 −3
Review log 1721
-
Tim Schreiner uploaded patch set 1 03/29/18, 21:32
-
TYPO3com voted on patch set 1 V +1 03/29/18, 21:42 Completed build in 09m 11s on Thu, 29 Mar, 11:42 PM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21873
-
Oliver Klee commented on patch set 1 CR -1 03/29/18, 22:17
I think this ticket number is not correct. (It's for a ticket about FE compression.) -
Tim Schreiner updated the commit message in patch set 2 03/29/18, 22:26
-
Tim Schreiner commented on patch set 2 03/29/18, 22:28
Sorry for wrong issue id. Copied next_issue_id from url instead of current one. It's correct now. -
TYPO3com voted on patch set 2 V +1 03/29/18, 22:34 Completed build in 07m 57s on Fri, 30 Mar, 12:34 AM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21874
-
Tymoteusz Motylewski commented on patch set 2 03/30/18, 13:19
I will provide acceptance tests for the FAL case. -
Tymoteusz Motylewski commented on patch set 2 04/05/18, 15:44
pushed the test here: https://review.typo3.org/#/c/56572/ once it's merged we will see if this patch is breaking it or not -
Tymoteusz Motylewski rebased onto patch set 3 04/16/18, 09:08
-
TYPO3com voted on patch set 3 V -1 04/16/18, 09:18 Completed build in 10m 15s on Mon, 16 Apr, 11:18 AM Test Summary: 1 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22388
-
Frans Saris voted on patch set 3 V +1 CR +1 04/16/18, 09:33
-
Frans Saris commented on patch set 3 04/16/18, 09:42
For me the behavior looks okay now. Think the failing test should be adjusted to represent this behavior. -
Frans Saris rebased onto patch set 4 05/16/18, 17:12
-
TYPO3com voted on patch set 4 V +1 05/16/18, 17:20 Completed build in 08m 45s on Wed, 16 May, 07:20 PM Test Summary: 31183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23571
-
Frans Saris voted on patch set 4 V +1 CR +1 05/16/18, 18:06
-
Alexander Stehlik voted on patch set 4 V +1 CR +1 05/16/18, 22:06
-
Markus Klein commented on patch set 4 CR -1 05/17/18, 08:12
reviewing -
Anja Leichsenring voted on patch set 4 V +1 CR +1 05/17/18, 08:13
-
Markus Klein voted on patch set 4 V +2 CR +2 05/17/18, 08:17
-
Markus Klein merged patch set 5 05/17/18, 08:17
-
Markus Klein commented on patch set 5 05/17/18, 08:17
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 83ee599b46bd767345666ddedb69fc5ce22a3d4c