Review main Merged

56488[TASK] Update CKEditor from 4.7.2 to 4.9.1

Josef Glatz CR +2 V +2 Nightmare +2279 −2217 updated 04/04/18, 12:08

Commit message

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/cke4/release-notes
https://ckeditor.com/cke4/release/CKEditor-4.7.3
https://ckeditor.com/cke4/release/CKEditor-4.8.0
https://ckeditor.com/cke4/release/CKEditor-4.9.0
https://ckeditor.com/cke4/release/CKEditor-4.9.1

@types/ckeditor has also been updated

Following commands were used to update dependencies:
- yarn add ckeditor@4.9.1 -E -D
- yarn add @types/ckeditor@0.0.46 -E -D

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Susi Moog +1
  • Verified V +2
    • Stefan Neufeind +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 658

Show 638 more files

Review log 1115

  1. Josef Glatz uploaded patch set 1 03/30/18, 06:56

  2. TYPO3com voted on patch set 1 V +1 03/30/18, 07:05 Completed build in 08m 33s on Fri, 30 Mar, 09:05 AM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21876

  3. Tymoteusz Motylewski commented on patch set 1 03/30/18, 08:39

    does v8.7 also requires an update?
  4. Josef Glatz commented on patch set 1 03/30/18, 10:15

    @tymek:The last update was reverted by Benni for 8.7. I personally would try to upgrade 8.7 only if there are enough people which can test all the common features and their plugins in use... there are even some small changes (-> release notes) – maybe a CKEditor contributer/profi can give a better assessment on this question? For 9.x I would tend to merge the update quickly. We can then test until the upcoming LTS (like we did when 8.x was master)
  5. Wouter Wolters commented on patch set 1 04/01/18, 11:39

    can you include your yarn command in the commit message too?
  6. Josef Glatz updated the commit message in patch set 2 04/04/18, 10:47

  7. Josef Glatz rebased onto patch set 3 04/04/18, 10:47

  8. Josef Glatz updated the commit message in patch set 4 04/04/18, 10:49

  9. Josef Glatz commented on patch set 4 04/04/18, 10:50

    > Patch Set 1: > > can you include your yarn command in the commit message too? Thanks! Done
  10. TYPO3com voted on patch set 2 V +1 04/04/18, 10:59 Completed build in 11m 44s on Wed, 4 Apr, 12:59 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21985

  11. TYPO3com voted on patch set 3 V +1 04/04/18, 11:00 Completed build in 12m 09s on Wed, 4 Apr, 01:00 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21986

  12. TYPO3com voted on patch set 4 V +1 04/04/18, 11:01 Completed build in 11m 53s on Wed, 4 Apr, 01:01 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21987

  13. Susi Moog commented on patch set 4 V +1 CR +1 04/04/18, 11:26

    tested with bootstrap package (which loads custom configuration and additional plugins)
  14. Stefan Neufeind commented on patch set 4 V +2 CR +2 04/04/18, 12:08

    Works for me (on limited test-cases of course)
  15. Stefan Neufeind merged patch set 5 04/04/18, 12:08