Review main Abandoned

56490[TASK] Update MediaViewHelper.php

TYPO3com CR 0 V 0 Easy +3 −1 updated 06/01/18, 12:13

Commit message

Allow additionalAttributes in function render
In some cases, it is useful to call the Render-Fuction with
additionalAttributes from your fluid-Template (e.g. by providing a
poster-Attribut with a video-Tag like <f:media
additionalAttributes="{poster: 'fallback-img.jpg'}" )
Alltough this additionalAttributes ist already registered by the Core at
this position, the function render() did not made use of it so far.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 36

  1. TYPO3com uploaded patch set 1 03/30/18, 16:13

  2. TYPO3com voted on patch set 1 V -1 03/30/18, 16:13 Completed build in 09s on Fri, 30 Mar, 06:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21884

  3. Jörg Bösche commented on patch set 2 05/29/18, 06:15

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 05/29/18, 06:23 Completed build in 07m 57s on Tue, 29 May, 08:23 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23857

  5. Anja Leichsenring commented on patch set 2 V -1 CR -1 06/01/18, 12:11

    the wanted functionality is already available using additionalConfig attribute. the patch itself is bogus, it changes the call to render in a way that will destroy the function (simply added an array parameter to the call where a boolean is expected). Please abandon.
  6. Andreas Kienast abandoned the change 06/01/18, 12:13