56490[TASK] Update MediaViewHelper.php
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 36
-
TYPO3com uploaded patch set 1 03/30/18, 16:13
-
TYPO3com voted on patch set 1 V -1 03/30/18, 16:13 Completed build in 09s on Fri, 30 Mar, 06:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21884
-
Jörg Bösche commented on patch set 2 05/29/18, 06:15
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 05/29/18, 06:23 Completed build in 07m 57s on Tue, 29 May, 08:23 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23857
-
Anja Leichsenring commented on patch set 2 V -1 CR -1 06/01/18, 12:11
the wanted functionality is already available using additionalConfig attribute. the patch itself is bogus, it changes the call to render in a way that will destroy the function (simply added an array parameter to the call where a boolean is expected). Please abandon. -
Andreas Kienast abandoned the change 06/01/18, 12:13