Review main Merged

56493[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Daniel Haupt CR +2 V +2 Normal +51 −7 updated 09/19/18, 14:02

Commit message

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stephan Großberndt +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2633

Show 68 earlier messages
  1. Daniel Haupt uploaded patch set 1 03/30/18, 17:09

  2. TYPO3com voted on patch set 1 V +1 03/30/18, 17:18 Completed build in 08m 38s on Fri, 30 Mar, 07:18 PM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21886

  3. Stephan Großberndt updated the commit message in patch set 2 03/30/18, 17:23

  4. Stephan Großberndt commented on patch set 2 03/30/18, 17:24

  5. TYPO3com voted on patch set 2 V +1 03/30/18, 17:31 Completed build in 08m 17s on Fri, 30 Mar, 07:31 PM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21887

  6. Stephan Großberndt commented on patch set 2 03/30/18, 17:32

    Thanks for your first contribution! :-)

    EditController.php:156

    Fetching the config from TCA is not needed for pi_flexform then as it seems - so this should be in the else case below

    EditController.php:160

    No need for type hints in code, IDE can infer type

    EditController.php:163

    Please use string contatenation like this instead: 'sheets/' . $this->P['flexFormSheetName'] . '/ROOT/el/' . $this->P['flexFormFieldName'] . '/TCEforms/config'
  7. Daniel Haupt uploaded patch set 3 03/30/18, 19:05

  8. Daniel Haupt wrote 03/30/18, 19:08

    Description set to "Address comments"
  1. TYPO3com voted on patch set 3 V +1 03/30/18, 19:13 Completed build in 08m 36s on Fri, 30 Mar, 09:13 PM Test Summary: 30930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21890

  2. Stephan Großberndt voted on patch set 3 CR +1 03/30/18, 19:20

  3. Benni Mack commented on patch set 3 03/31/18, 10:23

    Thanks for your contribution, Daniel. One thing I noticed that the EditPopup is now hardcoded to the field "pi_flexform" - how can we handle this more generic when other fields are defined as flexform as well?
  4. Daniel Haupt uploaded patch set 4 03/31/18, 15:42

  5. Daniel Haupt commented on patch set 4 03/31/18, 15:43

    > Patch Set 3: > > Thanks for your contribution, Daniel. One thing I noticed that the EditPopup is now hardcoded to the field "pi_flexform" - how can we handle this more generic when other fields are defined as flexform as well? Hi Benni, we can do the check on the field "flexFormFieldName", which is not provided on fields created by TCA.
  6. Daniel Haupt wrote 03/31/18, 15:44

    Description set to "generic flexform condition"
  7. TYPO3com voted on patch set 4 V +1 03/31/18, 15:50 Completed build in 08m 35s on Sat, 31 Mar, 05:50 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21892

  8. Daniel Haupt commented on patch set 4 04/02/18, 23:44

    I changed the condition to a more generic one and would be happy if we could get this one in :)

    EditController.php:156 Reply

    Done

    EditController.php:160 Reply

    Done

    EditController.php:163 Reply

    Done
  9. Stephan Großberndt commented on patch set 4 04/03/18, 08:33

    EditController.php:158

    is "data" correct here or should it rather be "P"?
  10. Daniel Haupt uploaded patch set 5 04/03/18, 13:40

  11. Daniel Haupt commented on patch set 5 04/03/18, 13:43

    Fixed the if condition and retested the code! Sorry for circumstances.

    EditController.php:158 Reply

    Done
  12. TYPO3com voted on patch set 5 V +1 04/03/18, 13:48 Completed build in 08m 23s on Tue, 3 Apr, 03:48 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21932

  13. Stephan Großberndt voted on patch set 5 CR +1 04/03/18, 16:08

  14. Joerg Kummer voted on patch set 5 V +1 08/22/18, 20:29

  15. Joerg Kummer voted on patch set 5 CR +1 08/22/18, 20:31

  16. Christian Kuhn commented on patch set 5 08/23/18, 08:41

    EditController.php:161

    i kinda dislike this path comparison - and it will not work with flex form sections. we should have a look on how this is solved at different fields. for instance the ajax controllers for select tree should do similar stuff.
  17. Christian Kuhn uploaded patch set 6 09/19/18, 11:40

  18. Christian Kuhn commented on patch set 6 V +1 CR +1 09/19/18, 11:43

    test: styleguide v8 / master current git - tx_styleguide_select -> edit record -> in flex -> selectMultipleSideBySide -> select_multiplesidebyside_1 -> select a record on left side -> edit pencil -> without patch a popup opens and closes directly again.
  19. Christian Kuhn updated the commit message in patch set 7 09/19/18, 11:48

  20. TYPO3com voted on patch set 6 V +1 09/19/18, 11:49 Completed build in 09m 12s on Wed, 19 Sep, 01:49 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28354

  21. TYPO3com voted on patch set 7 V +1 09/19/18, 11:59 Completed build in 10m 19s on Wed, 19 Sep, 01:59 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28355

  22. Andreas Kienast voted on patch set 7 V +1 CR +1 09/19/18, 12:02

  23. Stephan Großberndt voted on patch set 7 CR +1 09/19/18, 12:40

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 09/19/18, 14:02

  25. Anja Leichsenring merged patch set 8 09/19/18, 14:02