Review TYPO3_8-7 Merged

56494[BUGFIX] Do not sharpen images if GFX/processor_effects is -1

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 05/04/18, 11:12

Commit message

Sharpen images only if the install tool setting GFX/processor_effects is
set to 1 and not if it is set to 0 or -1

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stephan Großberndt +1
    • Jigal van Hemert +1
  • Verified V +2
    • Frank Nägler +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Guido Schmechel uploaded patch set 1 03/30/18, 23:53

  2. TYPO3com voted on patch set 1 V +1 03/31/18, 00:01 Completed build in 08m 04s on Sat, 31 Mar, 02:01 AM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2211

  3. Guido Schmechel commented on patch set 1 03/31/18, 00:29

    Current master isn't affected. If processor_effects is set, the value is 1, otherwise it is empty. We could at most streamline the processor_effects condition in the master.
  4. Stephan Großberndt updated the commit message in patch set 2 03/31/18, 07:06

  5. Stephan Großberndt commented on patch set 2 03/31/18, 07:10

    So processor_effects is an int because it was meant to contain other effect settings too? If not, lets make it a boolean and that in master too
  6. TYPO3com voted on patch set 2 V +1 03/31/18, 07:15 Completed build in 09m 13s on Sat, 31 Mar, 09:15 AM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2212

  7. Guido Schmechel commented on patch set 2 03/31/18, 08:19

    - In version 8 its an integer with these values: -1,0,1 (Input Number Field in the install tool) - In version 9 its a checkbox. Its deliver false or true
  8. Stephan Großberndt updated the commit message in patch set 3 03/31/18, 12:57

  9. Stephan Großberndt commented on patch set 3 CR +1 03/31/18, 12:57

    Thanks for the explanation
  10. TYPO3com voted on patch set 3 V +1 03/31/18, 13:10 Completed build in 13m 18s on Sat, 31 Mar, 03:10 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2213

  11. Guido Schmechel commented on patch set 3 03/31/18, 16:25

    And thanks for improving the commit message. Help is always welcome :-)
  12. Jigal van Hemert commented on patch set 3 V +1 CR +1 04/01/18, 12:39

    For some time already this option only had effect if it was set to 1.
  13. Frank Nägler voted on patch set 3 V +2 CR +2 05/04/18, 11:12

  14. Frank Nägler merged patch set 4 05/04/18, 11:12