Review main Merged

56499[BUGFIX] Fix the return type annotations of JsonView

Oliver Klee CR +2 V +2 Easy +3 −3 updated 04/04/18, 15:11

Commit message

transformValue will return the argument (mixed) untransformed if it is no
array or object and thus needs to return mixed as well.

transformObject will return a string for DateTime and hence needs to have
string as an additional return type.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Georg Ringer +1
  • Verified V +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Oliver Klee uploaded patch set 1 03/31/18, 18:43

  2. TYPO3com voted on patch set 1 V +1 03/31/18, 18:51 Completed build in 08m 04s on Sat, 31 Mar, 08:51 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21893

  3. Oliver Klee uploaded patch set 2 03/31/18, 19:07

  4. TYPO3com voted on patch set 2 V +1 03/31/18, 19:17 Completed build in 09m 18s on Sat, 31 Mar, 09:17 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21894

  5. Georg Ringer voted on patch set 2 CR +1 04/02/18, 13:43

  6. Georg Ringer voted on patch set 2 V +1 04/04/18, 13:08

  7. Daniel Goerz voted on patch set 2 V +1 CR +1 04/04/18, 13:10

  8. Stefan Neufeind voted on patch set 2 CR +1 04/04/18, 13:24

  9. Frank Nägler voted on patch set 2 V +2 CR +2 04/04/18, 15:10

  10. Frank Nägler merged patch set 3 04/04/18, 15:10

  11. Frank Nägler commented on patch set 3 04/04/18, 15:11

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0593496dd83df0f18eff6d95cae00833339d0048