56500[TASK] Use stricter types in JsonView and its test
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Mathias Schreiber +1
- Thomas Maroschik +1
- Wouter Wolters +1
- Kay Strobach +1
-
Verified V +2
- Georg Ringer +2
- Mathias Schreiber +1
- Thomas Maroschik +1
- Kay Strobach +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1924
-
Oliver Klee uploaded patch set 1 03/31/18, 19:08
-
TYPO3com voted on patch set 1 V -1 03/31/18, 19:08 Completed build in 18s on Sat, 31 Mar, 09:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21895
-
Oliver Klee uploaded patch set 2 03/31/18, 19:19
-
TYPO3com voted on patch set 2 V +1 03/31/18, 19:28 Completed build in 08m 54s on Sat, 31 Mar, 09:28 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21896
-
Georg Ringer commented on patch set 2 04/02/18, 13:46
-
Oliver Klee commented on patch set 2 04/02/18, 13:55
JsonView.php:193ReplyThanks! I've seen this multiple times as part of some "make ...Test notice free" change requests. Does this only apply to non-test code? And is this for the cases when we decide to lower the 9LTS requirements to PHP 7.1, or is this to make porting changes to other branches less work? -
Oliver Klee uploaded patch set 3 04/05/18, 14:35
-
Oliver Klee commented on patch set 3 04/05/18, 14:35
Rebased. -
TYPO3com voted on patch set 3 V +1 04/05/18, 14:47 Completed build in 12m 14s on Thu, 5 Apr, 04:47 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22048
-
Mathias Schreiber updated the commit message in patch set 4 04/08/18, 15:26
-
Mathias Schreiber commented on patch set 4 04/08/18, 15:27
I changed the commit msg tag to task, since we don't want to use CLEANUP anymore. -
TYPO3com voted on patch set 4 V +1 04/08/18, 15:35 Completed build in 08m 49s on Sun, 8 Apr, 05:35 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22208
-
Oliver Klee commented on patch set 4 04/08/18, 15:49
> I changed the commit msg tag to task, since we don't want to use CLEANUP anymore. Good to know. Thanks! -
Jan Stockfisch uploaded patch set 5 04/12/18, 15:37
-
Jan Stockfisch commented on patch set 5 04/12/18, 15:41
JsonViewTest.php:173General question: Isn't it better to avoid dynamic calling static methods? What is the preferred calling syntax (using $this, self or static)? -
TYPO3com voted on patch set 5 V +1 04/12/18, 15:47 Completed build in 09m 43s on Thu, 12 Apr, 05:47 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22291
-
Oliver Klee commented on patch set 5 04/12/18, 15:56
JsonViewTest.php:173ReplyThe consensus in the TYPO3 core seems to be to call the PHPUnit assertions with $this (which only applies to those, but not to static methods in general). -
Jan Stockfisch commented on patch set 5 04/12/18, 16:07
JsonViewTest.php:173ReplyQuestion was about assertion calls. Kind of forgot that point in my question ;) Alright, so we'll leave them dynamically. -
Mathias Schreiber voted on patch set 5 V +1 CR +1 04/16/18, 16:32
-
Wouter Wolters voted on patch set 5 CR +1 04/16/18, 18:12
-
Thomas Maroschik voted on patch set 5 V +1 CR +1 04/17/18, 20:14
-
Kay Strobach voted on patch set 5 V +1 CR +1 04/18/18, 08:15
-
Georg Ringer voted on patch set 5 V +2 CR +2 04/19/18, 06:59
-
Georg Ringer merged patch set 6 04/19/18, 06:59
JsonView.php:193