Review main Merged

56502[FEATURE] Add options and clipboard to filelist search

Guido Schmechel CR +2 V +2 Normal +168 −40 updated 02/21/20, 14:29

Commit message

Use the already existing functions for listOptions and
clipboard and integrate them into the filelist search view.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2337

Show 912 earlier messages
  1. Guido Schmechel uploaded patch set 1 03/31/18, 21:18

  2. TYPO3com voted on patch set 1 V +1 03/31/18, 21:26 Completed build in 08m 09s on Sat, 31 Mar, 11:26 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21899

  3. Wolfgang Klinger commented on patch set 1 V -1 04/06/18, 20:29

    I get no thumbnails in search, 'Extended view' doesn't change anything and every time I change one of the checkboxes or the clipboard I'm back at the standard list view and my search term and result is lost.
  4. Guido Schmechel commented on patch set 1 04/06/18, 23:58

    > Patch Set 1: Verified-1 > > I get no thumbnails in search, 'Extended view' doesn't change anything and every time I change one of the checkboxes or the clipboard I'm back at the standard list view and my search term and result is lost. The problem is: This form sends his request via POST. If you change an option in a checkbox this calls window.location.href. All info are lost.
  5. Oliver Klee commented on patch set 1 04/07/18, 09:19

    This looks more like a FEATURE to me than a BUGFIX (and hence only should be for master).
  6. Guido Schmechel commented on patch set 1 04/07/18, 11:38

    > Patch Set 1: > > (1 comment) Hi Oli, the ticket is markes as "Bugfix". You can argue over it, but that's how it would be in the 8 version. Who decides that last?
  7. Guido Schmechel uploaded patch set 2 04/08/18, 13:04

  8. TYPO3com voted on patch set 2 V +1 04/08/18, 13:15 Completed build in 10m 31s on Sun, 8 Apr, 03:15 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22204

  9. Guido Schmechel commented on patch set 2 04/08/18, 13:17

    Hint: The ExtendedView is different between searchAction() and listAction()
  10. Guido Schmechel uploaded patch set 3 10/03/18, 19:37

  11. Guido Schmechel updated the commit message in patch set 4 10/03/18, 19:38

  12. TYPO3com voted on patch set 3 V +1 10/03/18, 19:50 Completed build in 13m 19s on Wed, 3 Oct, 09:50 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29311

  1. TYPO3com voted on patch set 4 V +1 10/03/18, 19:51 Completed build in 13m 21s on Wed, 3 Oct, 09:51 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29312

  2. Josef Glatz commented on patch set 4 CR -1 10/03/18, 20:13

    Feature needs a RsT
  3. Frank Nägler commented on patch set 4 05/31/19, 12:41

    no activity since months, is anyone working on this patch anymore?
  4. Guido Schmechel uploaded patch set 5 06/01/19, 21:56

  5. TYPO3com voted on patch set 5 V -1 06/01/19, 22:10 Completed build in 14m 01s on Sun, 2 Jun, 12:10 AM Test Summary: 3 of 46817 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34133

  6. Guido Schmechel uploaded patch set 6 06/01/19, 22:38

  7. TYPO3com voted on patch set 6 V -1 06/01/19, 22:53 Completed build in 14m 33s on Sun, 2 Jun, 12:53 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34134

  8. Guido Schmechel uploaded patch set 7 06/02/19, 08:36

  9. TYPO3com voted on patch set 7 V -1 06/02/19, 08:46 Completed build in 09m 57s on Sun, 2 Jun, 10:46 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34135

  10. Benni Mack commented on patch set 7 02/15/20, 09:51

    Guido. Could you rebase this patch? I think it would be beneficial to have this added to v10.
  11. Guido Schmechel uploaded patch set 8 02/15/20, 20:38

  12. TYPO3com voted on patch set 8 V -1 02/15/20, 21:02 Completed build in 16m 21s on Sat, 15 Feb, 09:02 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-149

  13. TYPO3com commented on patch set 8 02/16/20, 11:53 Completed build in 21m 09s on Sun, 16 Feb, 11:53 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-166

  14. TYPO3com commented on patch set 8 02/18/20, 22:35 Completed build in 11h 23m 51s on Tue, 18 Feb, 10:35 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-166

  15. Benni Mack uploaded patch set 9 02/18/20, 22:38

  16. TYPO3com voted on patch set 9 V -1 02/18/20, 23:06 Completed build in 23m 26s on Tue, 18 Feb, 11:06 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-281

  17. TYPO3com commented on patch set 9 02/21/20, 12:07 Completed build in 13h 47m 49s on Fri, 21 Feb, 12:07 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-281

  18. Susi Moog uploaded patch set 10 02/21/20, 12:10

  19. Susi Moog voted on patch set 10 V +1 CR +1 02/21/20, 12:21

  20. TYPO3com voted on patch set 10 V +1 02/21/20, 12:40 Completed build in 19m 34s on Fri, 21 Feb, 12:40 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-393

  21. Daniel Goerz uploaded patch set 11 02/21/20, 12:49

  22. Daniel Goerz voted on patch set 11 V +1 CR +1 02/21/20, 12:51

  23. TYPO3com voted on patch set 11 V +1 02/21/20, 14:08 Completed build in 58m 46s on Fri, 21 Feb, 02:08 PM Test Summary: 71464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-397

  24. Susi Moog voted on patch set 11 V +2 CR +2 02/21/20, 14:29

  25. Susi Moog merged patch set 12 02/21/20, 14:29