56532[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Joshua Westerheide +1
- Anja Leichsenring +1
-
Verified V +2
- Andreas Kienast +2
- Joshua Westerheide +1
- Anja Leichsenring +1
- Sybille Peters +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1519
-
Andreas Kienast uploaded patch set 1 04/03/18, 19:08
-
TYPO3com voted on patch set 1 V +1 04/03/18, 19:19 Completed build in 11m 10s on Tue, 3 Apr, 09:19 PM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21947
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 04/03/18, 19:33
-
Andreas Kienast updated the commit message in patch set 2 04/04/18, 07:07
-
TYPO3com voted on patch set 2 V +1 04/04/18, 07:15 Completed build in 08m 36s on Wed, 4 Apr, 09:15 AM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21972
-
Sybille Peters commented on patch set 2 04/04/18, 08:02
"Show hidden content elements" is displayed now, but shouldn't it be "on" by default? (I deleted my user settings). -
Andreas Kienast commented on patch set 2 04/04/18, 08:07
> Patch Set 2: > > "Show hidden content elements" is displayed now, but shouldn't it be "on" by default? (I deleted my user settings). I'm not sure, tbh. I see why it fails, let me do a quick poll. -
Andreas Kienast commented on patch set 2 V -1 CR -1 04/04/18, 08:12
Will change the checkbox handling, the original fix is also bogus. -
Andreas Kienast uploaded patch set 3 04/04/18, 08:38
-
TYPO3com voted on patch set 3 V -1 04/04/18, 08:38 Completed build in 09s on Wed, 4 Apr, 10:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21977
-
Andreas Kienast uploaded patch set 4 04/04/18, 08:39
-
TYPO3com voted on patch set 4 V +1 04/04/18, 08:48 Completed build in 08m 35s on Wed, 4 Apr, 10:48 AM Test Summary: 30935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21978
-
Sybille Peters commented on patch set 4 V +1 04/04/18, 09:28
Looks good. -
Anja Leichsenring voted on patch set 4 V +1 CR +1 04/05/18, 17:55
-
Joshua Westerheide commented on patch set 4 04/06/18, 10:31
PageLayoutController.php:390This always matches if the `MOD_SETTINGS['tt_content_showHidden']` is set, even if its 0.PageLayoutController.php:878So if the checkbox is checked for one language it will also be checked for the other language? -
Andreas Kienast commented on patch set 4 04/06/18, 11:05
PageLayoutController.php:390ReplyNo, mind the negation. If the value is set (even set to 0), the whole condition evaluates to false.PageLayoutController.php:878ReplyYes, that's the behavior that's intended all the time. -
Joshua Westerheide commented on patch set 4 V +1 CR +1 04/06/18, 11:19
PageLayoutController.php:390ReplyDonePageLayoutController.php:878ReplyDone -
Andreas Kienast voted on patch set 4 V +2 CR +2 04/06/18, 14:54
-
Andreas Kienast merged patch set 5 04/06/18, 14:54