Review main Merged

56541[BUGFIX] Add conflicts with broken sf/finder versions

Helmut Hummel CR +2 V +2 Easy +6 −2 updated 04/04/18, 12:52

Commit message

A regression was introduced in symfony/finder
https://github.com/symfony/symfony/pull/26337

This caused PackageManager to not find any core packages
any more in case they were symlinked.

Composer command (after adding conflict):
composer update --lock

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • Nicole Hummel +1
    • Mathias Brodala +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Helmut Hummel uploaded patch set 1 04/04/18, 10:11

  2. Mathias Brodala voted on patch set 1 CR +1 04/04/18, 10:17

  3. TYPO3com voted on patch set 1 V +1 04/04/18, 10:19 Completed build in 07m 47s on Wed, 4 Apr, 12:19 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21981

  4. Nicole Hummel voted on patch set 1 V +1 CR +1 04/04/18, 10:25

  5. Georg Ringer voted on patch set 1 V +1 CR +1 04/04/18, 11:31

  6. Stefan Neufeind voted on patch set 1 V +2 CR +2 04/04/18, 12:52

  7. Stefan Neufeind merged patch set 2 04/04/18, 12:52