56544[TASK] Add hook to upload methods in GeneralUtility
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Neufeind +1
-
Verified V +2
- Andreas Kienast +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Frank Nägler uploaded patch set 1 04/04/18, 11:35
-
Georg Ringer commented on patch set 1 04/04/18, 11:38
-
TYPO3com voted on patch set 1 V +1 04/04/18, 11:45 Completed build in 09m 54s on Wed, 4 Apr, 01:45 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21989
-
Mathias Brodala commented on patch set 1 CR -1 04/04/18, 12:03
This is a feature, so nothing for v8 and v7. -
Mathias Brodala commented on patch set 1 CR 0 04/04/18, 12:11
As discussed with Georg this should be fine, risk of breakage is low. -
Andreas Kienast updated the commit message in patch set 2 04/04/18, 12:15
-
Andreas Kienast voted on patch set 2 CR +1 04/04/18, 12:15
-
TYPO3com voted on patch set 2 V +1 04/04/18, 12:25 Completed build in 10m 25s on Wed, 4 Apr, 02:25 PM Test Summary: 30915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21992
-
Stefan Neufeind voted on patch set 2 CR +1 04/04/18, 13:26
-
Oliver Hader commented on patch set 2 04/06/18, 07:30
GeneralUtility.php:3267Fine with \. In addition we could add an `?? null` to the is_array check to avoid new notices here -
Frank Nägler uploaded patch set 3 04/06/18, 07:40
-
TYPO3com voted on patch set 3 V +1 04/06/18, 07:49 Completed build in 09m 12s on Fri, 6 Apr, 09:49 AM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22073
-
Stefan Neufeind voted on patch set 3 V +1 CR +1 04/06/18, 14:36
-
Andreas Kienast voted on patch set 3 V +2 CR +2 04/06/18, 15:02
-
Andreas Kienast merged patch set 4 04/06/18, 15:02
-
Andreas Kienast commented on patch set 4 04/06/18, 15:02
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4879d77cc64d63af310dc79ac8c4343a9050a292
GeneralUtility.php:3231