Review TYPO3_8-7 Merged

56548[BUGFIX] Add conflicts with broken sf/finder versions

Stefan Neufeind CR +2 V +2 Easy +6 −2 updated 04/04/18, 13:29

Commit message

A regression was introduced in symfony/finder
https://github.com/symfony/symfony/pull/26337

This caused PackageManager to not find any core packages
any more in case they were symlinked.

Composer command (after adding conflict):
composer update --lock

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 710

  1. Stefan Neufeind uploaded patch set 1 04/04/18, 12:56

  2. Helmut Hummel commented on patch set 1 CR -1 04/04/18, 13:03

    change in typo3/sysext/core/composer.json is missing here
  3. Stefan Neufeind uploaded patch set 2 04/04/18, 13:05

  4. Stefan Neufeind voted on patch set 2 CR -1 04/04/18, 13:08

  5. Stefan Neufeind uploaded patch set 3 04/04/18, 13:10

  6. TYPO3com voted on patch set 1 V +1 04/04/18, 13:11 Completed build in 15m 38s on Wed, 4 Apr, 03:11 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2216

  7. Helmut Hummel voted on patch set 3 V +2 CR +2 04/04/18, 13:20

  8. Helmut Hummel merged patch set 4 04/04/18, 13:20

  9. TYPO3com voted on patch set 2 V +1 04/04/18, 13:21 Completed build in 15m 49s on Wed, 4 Apr, 03:21 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2217

  10. TYPO3com voted on patch set 3 V +1 04/04/18, 13:29 Completed build in 18m 12s on Wed, 4 Apr, 03:29 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2219