Review TYPO3_7-6 Merged

56549[BUGFIX] Add conflicts with broken sf/finder versions

Stefan Neufeind CR +2 V +2 Easy +4 −1 updated 04/04/18, 13:21

Commit message

A regression was introduced in symfony/finder
https://github.com/symfony/symfony/pull/26337

This caused PackageManager to not find any core packages
any more in case they were symlinked.

Composer command (after adding conflict):
composer update --lock

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Stefan Neufeind uploaded patch set 1 04/04/18, 13:00

  2. Helmut Hummel commented on patch set 1 04/04/18, 13:02

    composer.json:74

    since we depend on ^2.7 of finder, we can remove || 3.4.7 || 4.0.7 here
  3. Stefan Neufeind uploaded patch set 2 04/04/18, 13:06

  4. Stefan Neufeind voted on patch set 2 CR -1 04/04/18, 13:08

  5. TYPO3com voted on patch set 1 V +1 04/04/18, 13:08 Completed build in 08m 27s on Wed, 4 Apr, 03:08 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1423

  6. Helmut Hummel voted on patch set 2 CR +1 04/04/18, 13:09

  7. Helmut Hummel voted on patch set 2 V +1 04/04/18, 13:10

  8. Stefan Neufeind voted on patch set 2 CR 0 04/04/18, 13:13

  9. TYPO3com voted on patch set 2 V +1 04/04/18, 13:19 Completed build in 13m 07s on Wed, 4 Apr, 03:19 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1424

  10. Helmut Hummel voted on patch set 2 V +2 CR +2 04/04/18, 13:21

  11. Helmut Hummel merged patch set 3 04/04/18, 13:21