Review TYPO3_8-7 Merged

56552[BUGFIX] Fix the return type annotations of JsonView

Frank Nägler CR +2 V +2 Easy +3 −3 updated 04/04/18, 15:27

Commit message

transformValue will return the argument (mixed) untransformed if it is no
array or object and thus needs to return mixed as well.

transformObject will return a string for DateTime and hence needs to have
string as an additional return type.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Oliver Klee +1
  • Verified V +2
    • Frank Nägler +2
    • Oliver Klee +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Frank Nägler commented on patch set 1 04/04/18, 15:11

    Cherry Picked from branch master.
  2. Frank Nägler voted on patch set 1 V +2 CR +2 04/04/18, 15:11

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/04/18, 15:13

  4. TYPO3com voted on patch set 1 V +1 04/04/18, 15:25 Completed build in 13m 48s on Wed, 4 Apr, 05:25 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2223

  5. Frank Nägler merged patch set 2 04/04/18, 15:27