Review main Merged

56570[BUGFIX] Fix exception in clipboard inside recycler folders

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/14/18, 13:20

Commit message

To avoid exceptions in a _recycler_ folder in the filelist when
using the clipboard, the image is built without an ImageViewHelper.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Markus Klein +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2226

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 04/05/18, 15:19

  1. TYPO3com voted on patch set 1 V +1 04/05/18, 15:28 Completed build in 08m 14s on Thu, 5 Apr, 05:28 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22053

  2. Guido Schmechel voted on patch set 1 V +1 CR +1 04/05/18, 15:40

  3. Oliver Klee commented on patch set 1 04/05/18, 16:11

    TabContent.html:21

    Shouldn't that be img instead of image then?
  4. Guido Schmechel commented on patch set 1 V 0 CR 0 04/05/18, 18:26

    Image work as synonym

    TabContent.html:21 Reply

    image is a synonym but better would be img. You're right.
  5. Wolfgang Klinger uploaded patch set 2 04/06/18, 18:33

  6. Wolfgang Klinger voted on patch set 2 CR +1 04/06/18, 18:34

  7. TYPO3com voted on patch set 2 V +1 04/06/18, 18:44 Completed build in 10m 37s on Fri, 6 Apr, 08:44 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22157

  8. Jörg Bösche voted on patch set 2 CR +1 04/06/18, 19:34

  9. Mathias Schreiber voted on patch set 2 V +1 CR +1 04/08/18, 13:49

  10. Guido Schmechel voted on patch set 2 V +1 CR +1 04/08/18, 13:56

  11. Oliver Klee voted on patch set 2 CR +1 04/08/18, 14:05

  12. Markus Klein updated the commit message in patch set 3 04/10/18, 11:49

  13. Markus Klein commented on patch set 3 04/10/18, 11:49

    TabContent.html:21

    should be self-closing
  14. Markus Klein commented on patch set 4 04/10/18, 11:50

    Published edit on patch set 3.
  15. Markus Klein voted on patch set 4 CR +1 04/10/18, 11:50

  16. TYPO3com voted on patch set 3 V +1 04/10/18, 11:58 Completed build in 09m 20s on Tue, 10 Apr, 01:58 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22256

  17. TYPO3com voted on patch set 4 V +1 04/10/18, 12:01 Completed build in 11m 02s on Tue, 10 Apr, 02:01 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22257

  18. Wouter Wolters voted on patch set 4 CR +1 04/10/18, 18:04

  19. Oliver Klee voted on patch set 4 CR +1 04/10/18, 22:47

  20. Guido Schmechel voted on patch set 4 V +1 CR +1 04/11/18, 05:32

  21. Jörg Bösche voted on patch set 4 V +1 CR +1 04/11/18, 15:29

  22. Anja Leichsenring voted on patch set 4 V +1 CR +1 04/14/18, 13:15

  23. Wouter Wolters voted on patch set 4 V +2 CR +2 04/14/18, 13:20

  24. Wouter Wolters merged patch set 5 04/14/18, 13:20

  25. Wouter Wolters commented on patch set 5 04/14/18, 13:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ce1a9b26262b0a0c1192345ee0f5090583d646c8