56571[BUGFIX] Add missing column in database query
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Simon Gilli +1
- Anja Leichsenring +1
-
Verified V +2
- Nicole Hummel +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2428
Show 23 earlier messages
-
Georg Ringer uploaded patch set 1 04/05/18, 15:31
-
TYPO3com voted on patch set 1 V +1 04/05/18, 15:40 Completed build in 09m 52s on Thu, 5 Apr, 05:40 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22055
-
Tymoteusz Motylewski voted on patch set 1 CR +1 04/05/18, 21:02
-
Wouter Wolters voted on patch set 1 CR +1 04/05/18, 21:07
-
Mathias Brodala voted on patch set 1 CR +1 04/06/18, 07:34
-
Daniel Goerz commented on patch set 1 CR -1 04/06/18, 18:05
Just indicating the reported error (with applied patch set) from the forge issue. -
Mathias Schreiber commented on patch set 1 04/08/18, 13:55
> Patch Set 1: Code-Review-1 > > Just indicating the reported error (with applied patch set) from the forge issue. I don't understand the -1. Can you help me out here? -
Daniel Goerz commented on patch set 1 04/08/18, 14:01
> I don't understand the -1. > Can you help me out here? If I am not mistaken Andrej K who seems to have the matching environemnt to reproduce this issue commented on forge that with the patch set applied there is still an error. He commented on forge but did not -1 the patch, so I did that. In case I am misunderstanding something, please ignore my vote and I am sorry :) -
Mathias Schreiber commented on patch set 1 04/08/18, 14:03
> He commented on forge but did not -1 the patch, so I did that. In case I am misunderstanding something, please ignore my vote and I am sorry :) Ah, now I see... thanks for the hint -
Susi Moog commented on patch set 1 04/10/18, 11:52
TypoScriptTemplateModuleController.php:211sorting is probably missing, too and causing the error - all columns from order and group by should be part of the select iirc -
Andrej K commented on patch set 1 CR -1 04/11/18, 18:10
Daniel Goerz is right, the SQL issue persists when you access the Template menu. However, the error message is different (it's on the forge). -
Susi Moog commented on patch set 2 04/12/18, 16:01
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/12/18, 16:10 Completed build in 09m 30s on Thu, 12 Apr, 06:10 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22293
-
Nicole Hummel commented on patch set 2 CR -1 04/12/18, 17:30
IMHO pid and sorting is missing in select() now completely?! -
Simon Gilli uploaded patch set 3 04/12/18, 19:14
-
Simon Gilli commented on patch set 3 04/12/18, 19:17
> Patch Set 2: Code-Review-1 > > IMHO pid and sorting is missing in select() now completely?! DoneTypoScriptTemplateModuleController.php:211ReplyDone -
TYPO3com voted on patch set 3 V +1 04/12/18, 19:22 Completed build in 08m 08s on Thu, 12 Apr, 09:22 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22296
-
Simon Gilli uploaded patch set 4 04/12/18, 20:27
-
TYPO3com voted on patch set 4 V +1 04/12/18, 20:35 Completed build in 08m 25s on Thu, 12 Apr, 10:35 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22297
-
Simon Gilli commented on patch set 4 CR +1 04/12/18, 20:37
> Patch Set 2: Code-Review-1 > > IMHO pid and sorting is missing in select() now completely?! the 2 fields are not used, they only must be added to the grouped by clause (or a aggregate function but that's not fitting here) because they are used in order by. susi's solution is absolutley correct -
Nicole Hummel commented on patch set 4 04/12/18, 21:13
Thanks for clarification. I just wondered because it was Susi mentioning "all columns from order and group by should be part of the select iirc" -
Susi Moog commented on patch set 4 04/13/18, 08:58
> Thanks for clarification. I just wondered because it was Susi > mentioning "all columns from order and group by should be part of > the select iirc" yes, I wrote stupid things in the comment, noticed that afterwards ;) Simon explained it well, thanks. -
Simon Gilli commented on patch set 4 04/13/18, 09:53
> Patch Set 4: > > > Thanks for clarification. I just wondered because it was Susi > > mentioning "all columns from order and group by should be part of > > the select iirc" > > yes, I wrote stupid things in the comment, noticed that afterwards ;) Simon explained it well, thanks. and i did a stupid patch ;) have a look at the issue, Stephan Großberndt posted the sql servers error message which says it all -
Simon Gilli commented on patch set 4 04/13/18, 09:59
> Patch Set 4: > > > Patch Set 4: > > > > > Thanks for clarification. I just wondered because it was Susi > > > mentioning "all columns from order and group by should be part of > > > the select iirc" > > > > yes, I wrote stupid things in the comment, noticed that afterwards ;) Simon explained it well, thanks. > > and i did a stupid patch ;) have a look at the issue, Stephan Großberndt posted the sql servers error message which says it all unfortunately i wasn't able to fully test it on a server because my old windows hosting env uses php5 and i wasn't able to quickly install php7. but i tested a similar query on a comparable database in ms sql and did various tests. so it seems to be ok so far... -
Anja Leichsenring voted on patch set 4 V +1 CR +1 04/14/18, 13:08
-
Nicole Hummel voted on patch set 4 V +2 CR +2 04/14/18, 13:13
-
Nicole Hummel merged patch set 5 04/14/18, 13:13
-
Nicole Hummel commented on patch set 5 04/14/18, 13:14
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 85faf4ff66c96e135d58636f87ce77ee33dbe744