Review main Merged

56572[TASK] Cover adding image to tt_content with acceptance tests

Tymoteusz Motylewski CR +2 V +2 Normal +202 −0 updated 04/15/18, 09:53

Commit message

Add acceptance tests for adding image to tt_content,
when image has metadata filled or not.
As a side effect, it covers https://review.typo3.org/56438
with test.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1013

  1. Tymoteusz Motylewski uploaded patch set 1 04/05/18, 15:42

  2. TYPO3com voted on patch set 1 V -1 04/05/18, 15:43 Completed build in 09s on Thu, 5 Apr, 05:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22056

  3. Tymoteusz Motylewski uploaded patch set 2 04/05/18, 15:44

  4. TYPO3com voted on patch set 2 V +1 04/05/18, 15:54 Completed build in 09m 28s on Thu, 5 Apr, 05:54 PM Test Summary: 30926 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22057

  5. Oliver Klee commented on patch set 3 04/06/18, 08:03

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 04/06/18, 08:14 Completed build in 11m 22s on Fri, 6 Apr, 10:14 AM Test Summary: 30926 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22076

  7. Jörg Bösche voted on patch set 3 CR +1 04/06/18, 19:37

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/14/18, 13:16

  9. Wouter Wolters voted on patch set 3 CR +1 04/14/18, 13:34

  10. Andreas Kienast voted on patch set 3 CR +1 04/15/18, 09:03

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 04/15/18, 09:53

  12. Andreas Kienast merged patch set 4 04/15/18, 09:53

  13. Andreas Kienast commented on patch set 4 04/15/18, 09:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c5b12a2fa248943e8a0447c2fbcf82553ed9b657