Review main Merged

56575[BUGFIX] Correct wrong type annotation for drawItem_footer hook

Joshua Westerheide CR +2 V +2 Easy +1 −1 updated 04/06/18, 14:51

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Tim Schreiner +1
  • Verified V +2
    • Jan Helke +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Tim Schreiner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Joshua Westerheide uploaded patch set 1 04/06/18, 07:31

  2. TYPO3com voted on patch set 1 V +1 04/06/18, 07:40 Completed build in 08m 48s on Fri, 6 Apr, 09:40 AM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22072

  3. Oliver Klee updated the commit message in patch set 2 04/06/18, 08:01

  4. TYPO3com voted on patch set 2 V +1 04/06/18, 08:12 Completed build in 10m 48s on Fri, 6 Apr, 10:12 AM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22075

  5. Jan Helke commented on patch set 2 04/06/18, 09:13

    The patch seems ok to me. But why should be backport it to 7.6?
  6. Joshua Westerheide commented on patch set 2 04/06/18, 09:15

    > Patch Set 2: > > The patch seems ok to me. But why should be backport it to 7.6? You don't have to. But its also an issue in 7.6.
  7. Jan Helke commented on patch set 2 04/06/18, 09:22

    Yes. It is in fact an issue in 7.6 But we have two competeting requirements here. - According to our roadmap, 7.6 is in the "priority bugfix" phase of its livecycle. So nothing trivial should be merged into it to mitigate any risk. - According to your commit message you want this into 7.6. Thats, what the line "Releases" tell: "I, the developer, want this patch in version x, y, and z." My suggestion would be: Just remove the 7.6 from the Releases line and erverything would be fine.
  8. Jan Helke commented on patch set 2 04/06/18, 09:22

    PS: Yes, I could do this change to. But it would be rude to not inform you about this.
  9. Joshua Westerheide updated the commit message in patch set 3 04/06/18, 09:22

  10. Jan Helke voted on patch set 3 V +1 CR +1 04/06/18, 09:23

  11. Wouter Wolters voted on patch set 3 CR +1 04/06/18, 09:25

  12. TYPO3com voted on patch set 3 V +1 04/06/18, 09:32 Completed build in 09m 01s on Fri, 6 Apr, 11:32 AM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22091

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 04/06/18, 10:16

  14. Jan Helke voted on patch set 3 V +2 CR +2 04/06/18, 10:18

  15. Tim Schreiner voted on patch set 3 V +1 CR +1 04/06/18, 14:23

  16. Andreas Kienast voted on patch set 3 V +2 CR +2 04/06/18, 14:51

  17. Andreas Kienast merged patch set 4 04/06/18, 14:51

  18. Andreas Kienast commented on patch set 4 04/06/18, 14:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit dd682721881c6736de2c5ff46902c675d18585cf