Review main Merged

56576[TASK] Move linkData() functionality in PageLinkBuilder

Benni Mack CR +2 V +2 Hard +314 −10 updated 04/06/18, 11:35

Commit message

The "mother of building all links in Frontend" is moved
into PageLinkBuilder. Along with this, building a
mountPointMap is moved into the PageLinkBuilder as well,
as this is solely needed.

Existing methods are deprecated:
 * TemplateService->linkData
 * TemplateService->getFromMPmap
 * TemplateService->initMPmap_create

The existing hook is moved into PageLinkBuilder as well,
so functionality like RealURL will work the same.

Review

  • Code review CR +2
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1115

  1. Benni Mack uploaded patch set 1 04/06/18, 08:06

  2. TYPO3com voted on patch set 1 V -1 04/06/18, 08:16 Completed build in 09m 49s on Fri, 6 Apr, 10:16 AM Test Summary: 14 of 31076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22077

  3. Benni Mack uploaded patch set 2 04/06/18, 08:17

  4. Susi Moog voted on patch set 2 CR +1 04/06/18, 08:23

  5. TYPO3com voted on patch set 2 V -1 04/06/18, 08:26 Completed build in 08m 34s on Fri, 6 Apr, 10:26 AM Test Summary: 2 of 31076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22078

  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 04/06/18, 08:30

  7. Mathias Schreiber wrote 04/06/18, 08:49

    Removed Code-Review+1 by Mathias Schreiber <mathias.schreiber@typo3.com>
  8. Mathias Schreiber wrote 04/06/18, 08:49

    Removed Verified+1 by Mathias Schreiber <mathias.schreiber@typo3.com>
  9. Anja Leichsenring uploaded patch set 3 04/06/18, 09:52

  10. TYPO3com voted on patch set 3 V -1 04/06/18, 09:52 Completed build in 11s on Fri, 6 Apr, 11:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22096

  11. Anja Leichsenring uploaded patch set 4 04/06/18, 09:59

  12. TYPO3com voted on patch set 4 V +1 04/06/18, 10:09 Completed build in 10m 23s on Fri, 6 Apr, 12:09 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22097

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 04/06/18, 10:17

  14. Susi Moog voted on patch set 4 V +2 CR +2 04/06/18, 11:35

  15. Susi Moog merged patch set 5 04/06/18, 11:35