Review main Abandoned

56578[BUGFIX] Show executed SQL statements in Upgrade Wizard

Sybille Peters CR 0 V 0 Easy +9 −2 updated 09/30/18, 17:13

Commit message

If the checkbox is selected, SQL statements should be displayed
with flash messages.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1013

  1. Sybille Peters uploaded patch set 1 04/06/18, 09:16

  2. TYPO3com voted on patch set 1 V -1 04/06/18, 09:16 Completed build in 28s on Fri, 6 Apr, 11:16 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22090

  3. Sybille Peters updated the commit message in patch set 2 04/06/18, 09:32

  4. TYPO3com voted on patch set 2 V -1 04/06/18, 09:32 Completed build in 10s on Fri, 6 Apr, 11:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22092

  5. Sybille Peters uploaded patch set 3 04/06/18, 09:36

  6. Sybille Peters wrote 04/06/18, 09:38

    Description set to "Fixed cgl issue"
  7. TYPO3com voted on patch set 3 V +1 04/06/18, 09:47 Completed build in 10m 57s on Fri, 6 Apr, 11:47 AM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22094

  8. Jan Helke commented on patch set 3 CR -1 04/06/18, 10:17

    UpgradeWizardsService.php:380

    That doesn't work as expected, because Doctrine doesn't return a complete statement but only something like UPDATE `sys_language` SET `sorting` = :dcValue2 WHERE `uid` = :dcValue1 And that for every entry in sys_language.
  9. Sybille Peters commented on patch set 3 04/06/18, 11:04

    UpgradeWizardsService.php:380 Reply

    Cool, I missed that. The fix here is probably ok, but the various performUpdate functions would need to get fixed to return the actual SQL statements. Not sure if that is a good idea: "There is no simple solution to show the fully replaced query from within the framework, but you can go for ->getParameters() to see the array of parameters used to replace these placeholders within the query." https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/Database/QueryBuilder/Index.html#getsql
  10. Simon Gilli commented on patch set 3 CR -1 04/07/18, 19:21

    UpgradeController.php:879

    rotate and get $identifier from $requestBody

    UpgradeWizardsService.php:340 Unresolved

    never used, add this to message (what probably was planed but never finished) or delete it
  11. Sybille Peters commented on patch set 3 04/07/18, 19:24

    UpgradeController.php:879 Reply

    Ack
  12. Mathias Schreiber commented on patch set 3 04/08/18, 08:04

    UpgradeWizardsService.php:380 Reply

    > Not sure if that is a good idea: It's not. Prepared statements are built to do just that: Optimize a query without parameters, then run the optimized query WITH parameters.
  13. Christian Kuhn abandoned the change 09/30/18, 17:13

    Hey. I'll go ahead and will abandon this patch for now: The feature has always been implemented half-way and is gone in v9. I don't think it makes *that* much sense to re-imlement it for v8 again.