Review main Merged

56582[BUGFIX] Do not try to download extensions in composer mode

Helmut Hummel CR +2 V +2 Easy +29 −13 updated 04/07/18, 05:25

Commit message

Upgrade wizards that download extensions from TER must
no do so in composer mode as they would create an unusable
system.

But in case the extension is found, in the system, these wizards
still activate them.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Joshua Westerheide +1
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Joshua Westerheide +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2129

Show 34 earlier messages
  1. Helmut Hummel uploaded patch set 1 04/06/18, 10:55

  2. TYPO3com voted on patch set 1 V -1 04/06/18, 11:04 Completed build in 08m 49s on Fri, 6 Apr, 01:04 PM Test Summary: 3 of 31076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22105

  3. Mathias Brodala commented on patch set 1 04/06/18, 11:04

    Would it make sense to extend the current API to optionally pass in the package name which could then be shown directly? Right now people would need to figure out the package name on themselves.
  4. Susi Moog commented on patch set 1 04/06/18, 11:24

    > Would it make sense to extend the current API to optionally pass in > the package name which could then be shown directly? Right now > people would need to figure out the package name on themselves. had the same idea ;) will try to update the patch.
  1. Susi Moog uploaded patch set 2 04/06/18, 11:50

  2. Oliver Klee commented on patch set 2 04/06/18, 11:52

    The ticket number is missing here.
  3. Susi Moog uploaded patch set 3 04/06/18, 11:55

  4. TYPO3com voted on patch set 2 V -1 04/06/18, 12:00 Completed build in 10m 50s on Fri, 6 Apr, 02:00 PM Test Summary: 3 of 31076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22111

  5. TYPO3com voted on patch set 3 V +1 04/06/18, 12:09 Completed build in 14m 11s on Fri, 6 Apr, 02:09 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22114

  6. Oliver Klee commented on patch set 3 CR -1 04/06/18, 12:17

    The issue number still is missing.
  7. Mathias Brodala updated the commit message in patch set 4 04/06/18, 12:28

  8. Mathias Brodala commented on patch set 5 04/06/18, 12:32

    Published edit on patch set 4.
  9. Mathias Brodala commented on patch set 6 04/06/18, 12:38

    Published edit on patch set 5.
  10. Mathias Brodala commented on patch set 6 04/06/18, 12:38

    Slightly streamlined checks.
  11. TYPO3com voted on patch set 4 V +1 04/06/18, 12:39 Completed build in 10m 03s on Fri, 6 Apr, 02:39 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22120

  12. TYPO3com voted on patch set 5 V +1 04/06/18, 12:41 Completed build in 09m 47s on Fri, 6 Apr, 02:41 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22121

  13. TYPO3com voted on patch set 6 V +1 04/06/18, 12:47 Completed build in 09m 11s on Fri, 6 Apr, 02:47 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22122

  14. Mathias Brodala voted on patch set 6 V +1 CR +1 04/06/18, 14:02

  15. Helmut Hummel commented on patch set 6 CR -1 04/06/18, 14:03

    AbstractDownloadExtensionUpdate.php:68

    I avoided the nested if on purpose. will push a new version
  16. Helmut Hummel uploaded patch set 7 04/06/18, 14:08

  17. Joshua Westerheide commented on patch set 7 04/06/18, 14:14

    AbstractDownloadExtensionUpdate.php:99 Unresolved

    Maybe we should include the version of the package? Stupid copy & pasting would lead to more trouble.
  18. Joshua Westerheide uploaded patch set 8 04/06/18, 14:17

  19. Mathias Brodala voted on patch set 8 V +1 CR +1 04/06/18, 14:18

  20. TYPO3com voted on patch set 7 V +1 04/06/18, 14:18 Completed build in 09m 31s on Fri, 6 Apr, 04:18 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22128

  21. TYPO3com voted on patch set 8 V +1 04/06/18, 14:27 Completed build in 10m 07s on Fri, 6 Apr, 04:27 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22131

  22. Joshua Westerheide voted on patch set 8 V +1 CR +1 04/06/18, 14:33

  23. Daniel Goerz voted on patch set 8 V +1 CR +1 04/06/18, 17:51

  24. Georg Ringer voted on patch set 8 V +2 CR +2 04/07/18, 05:25

  25. Georg Ringer merged patch set 9 04/07/18, 05:25