Review TYPO3_8-7 Merged

56590[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary

Anja Leichsenring CR +2 V +2 Easy +33 −15 updated 04/06/18, 15:23

Commit message

The checkbox "Show hidden content elements" currently checks any selected
language. This is malfunctioning in case the language "Default" is
selected in the "Language" view, as it won't affect any translation.

The patch now changes the handling to add the language constraint only if
the view renders multiple languages and any language is selected, that is
not the default language.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Anja Leichsenring uploaded patch set 1 04/06/18, 15:07

  2. TYPO3com voted on patch set 1 V +1 04/06/18, 15:20 Completed build in 13m 24s on Fri, 6 Apr, 05:20 PM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2246

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/06/18, 15:23

  4. Andreas Kienast merged patch set 2 04/06/18, 15:23