56608[TASK] Deprecate unused extension install method
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1115
-
Helmut Hummel uploaded patch set 1 04/08/18, 13:11
-
TYPO3com voted on patch set 1 V +1 04/08/18, 13:22 Completed build in 11m 50s on Sun, 8 Apr, 03:22 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22207
-
Georg Ringer uploaded patch set 2 04/10/18, 12:08
-
TYPO3com voted on patch set 2 V +1 04/10/18, 12:18 Completed build in 09m 18s on Tue, 10 Apr, 02:18 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22259
-
Susi Moog commented on patch set 2 CR -1 04/10/18, 12:30
ExtensionScanner please ;) -
Georg Ringer uploaded patch set 3 04/10/18, 17:28
-
TYPO3com voted on patch set 3 V +1 04/10/18, 17:37 Completed build in 09m 01s on Tue, 10 Apr, 07:37 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22266
-
Susi Moog voted on patch set 3 CR +1 04/10/18, 18:55
-
Helmut Hummel commented on patch set 3 CR -1 04/10/18, 19:40
Thanks Georg for picking up this. I have some comments thoughDeprecation-84685-DeprecateAbstractUpdateinstallExtensions.rst:24that is not correct. update classes should extend AbstractExtensionUpdate instead if these need to install extensionsMethodCallMatcher.php:2119I don’t know the machers well, but is this really correct? that method name is the same as class name? -
Susi Moog wrote 04/12/18, 15:51
Removed Code-Review+1 by Susanne Moog <susanne.moog@typo3.org> -
Susi Moog commented on patch set 4 04/12/18, 15:55
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 04/12/18, 16:03 Completed build in 08m 17s on Thu, 12 Apr, 06:03 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22292
-
Nicole Hummel commented on patch set 4 CR -1 04/12/18, 20:28
AbstractUpdate.php:148As stated in the rst file yoou should extend AbstractDownloadExtensionUpdate -
Susi Moog wrote 07/30/18, 12:58
Removed reviewer Susanne Moog. -
Helmut Hummel abandoned the change 09/17/18, 13:21