Review main Merged

56609[BUGFIX] Keep sorting column value for deleted records

Tim Schreiner CR +2 V +2 Expert +614 −584 updated 04/09/18, 11:32

Commit message

Keep the value for the defined sorting field when a record is
deleted. This improves the quality of restored records especially
for tt_content records when a whole page is restored.

This change might be breaking for functional tests in third-party
extensions that rely on deleted records.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Jan Stockfisch +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 82

Show 62 more files

Review log 1012

  1. Tim Schreiner uploaded patch set 1 04/08/18, 15:40

  2. TYPO3com voted on patch set 1 V +1 04/08/18, 15:49 Completed build in 09m 18s on Sun, 8 Apr, 05:49 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22209

  3. Mathias Brodala commented on patch set 1 CR -1 04/09/18, 07:28

    This is a TASK/BUGFIX.
    rely

    Breaking-84658-KeepSortingForDeletedRecords.rst:4

    I'd say this only needs to be Important. Otherwise please add "[!!!]" to the commit title.
  4. Tim Schreiner uploaded patch set 2 04/09/18, 07:45

  5. Tim Schreiner commented on patch set 2 04/09/18, 07:50

    Maybe this patch should be backported to TYPO3 8 but because of breaking some functional tests in third party extensions, I'm not sure if that should be done. Any suggestions for that?

    Reply

    I changed it to BUGFIX because that is more accurate I think.

    Reply

    Done

    Breaking-84658-KeepSortingForDeletedRecords.rst:4 Reply

    Changed it to Important. Also set correct issue ref in this line.
  6. TYPO3com voted on patch set 2 V +1 04/09/18, 07:54 Completed build in 08m 15s on Mon, 9 Apr, 09:54 AM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22216

  7. Mathias Brodala commented on patch set 2 04/09/18, 07:57

    > (3 comments) > > Maybe this patch should be backported to TYPO3 8 but because of > breaking some functional tests in third party extensions, I'm not > sure if that should be done. > Any suggestions for that? Given the hassle this can cause I'd vote against backporting to v8.
  8. Mathias Brodala commented on patch set 2 V +1 CR +1 04/09/18, 07:58

    Verified by Bamboo.
  9. Tim Schreiner commented on patch set 2 04/09/18, 08:01

    > Patch Set 2: > > > (3 comments) > > > > Maybe this patch should be backported to TYPO3 8 but because of > > breaking some functional tests in third party extensions, I'm not > > sure if that should be done. > > Any suggestions for that? > > Given the hassle this can cause I'd vote against backporting to v8. Okay, that was also my thought. Then this change stays just for master
  10. Jan Stockfisch voted on patch set 2 V +1 04/09/18, 08:50

  11. Georg Ringer voted on patch set 2 V +2 CR +2 04/09/18, 11:32

  12. Georg Ringer merged patch set 3 04/09/18, 11:32