56609[BUGFIX] Keep sorting column value for deleted records
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Mathias Brodala +1
-
Verified V +2
- Georg Ringer +2
- Jan Stockfisch +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 82
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+0 −4
- typo3/sysext/core/Documentation/Changelog/master/Important-84658-KeepSortingForDeletedRecords.rstnew+34 −0
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/deleteContent.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/deleteContentOfRelation.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/deleteElementOfRelation.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/deletePage.csv+17 −17
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/deleteParentContent.csv+4 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/modifyParentNDeleteHotelChild.csv+3 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/deletePage.csv+18 −18
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/deleteParentContent.csv+4 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/modifyParentNDeleteHotelChild.csv+3 −3
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/Modify/DataSet/deleteCategoryOfRelation.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/Modify/DataSet/deleteContentOfRelation.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/deleteContent.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/deleteLocalizedContentNDeleteContent.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/deletePage.csv+7 −7
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/DataSet/deleteContentOfRelation.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/DataSet/deleteElementOfRelation.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Publish/DataSet/deleteContent.csv+2 −2
Show 62 more files
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/PublishAll/DataSet/deleteContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Publish/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Publish/DataSet/deleteElementOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/PublishAll/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/PublishAll/DataSet/deleteElementOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/deletePage.csv+32 −32
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/deleteParentContent.csv+8 −8
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/deletePage.csv+32 −32
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/deleteParentContent.csv+8 −8
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/modifyParentNDeleteHotelChild.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/deletePage.csv+34 −34
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/deleteParentContent.csv+8 −8
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/modifyParentNDeleteHotelChild.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNCopyParentNHotelNOfferChildrenNDiscardCopiedParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardCreatedParent.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNLocParentNHotelNOfferChildrenNDiscardLocParent.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/deletePage.csv+34 −34
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/deleteParentContent.csv+8 −8
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/modifyParentNDeleteHotelChild.csv+6 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Publish/DataSet/deleteCategoryOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Publish/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/PublishAll/DataSet/deleteCategoryOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/PublishAll/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingNDeleteLiveRecord.csv+9 −9
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingNDeleteMovedRecord.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPlaceholdersAndDeleteLiveParentPage.csv+18 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createPlaceholdersAndDeleteDraftParentPage.csv+21 −21
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/deleteContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/deleteContentAndPage.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/deleteLocalizedContentNDeleteContent.csv+4 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/deletePage.csv+11 −11
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createContentNDiscardCreatedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createNCopyContentNDiscardCopiedContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createPlaceholdersAndDeleteDraftParentPage.csv+21 −21
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createPlaceholdersAndDeleteLiveParentPage.csv+18 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/deleteContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/deleteContentAndPage.csv+12 −12
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/deleteLocalizedContentNDeleteContent.csv+4 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/deletePage.csv+11 −11
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Publish/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Publish/DataSet/deleteElementOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/PublishAll/DataSet/deleteContentOfRelation.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/PublishAll/DataSet/deleteElementOfRelation.csv+2 −2
Review log 1012
-
Tim Schreiner uploaded patch set 1 04/08/18, 15:40
-
TYPO3com voted on patch set 1 V +1 04/08/18, 15:49 Completed build in 09m 18s on Sun, 8 Apr, 05:49 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22209
-
Mathias Brodala commented on patch set 1 CR -1 04/09/18, 07:28
This is a TASK/BUGFIX.relyBreaking-84658-KeepSortingForDeletedRecords.rst:4I'd say this only needs to be Important. Otherwise please add "[!!!]" to the commit title. -
Tim Schreiner uploaded patch set 2 04/09/18, 07:45
-
Tim Schreiner commented on patch set 2 04/09/18, 07:50
Maybe this patch should be backported to TYPO3 8 but because of breaking some functional tests in third party extensions, I'm not sure if that should be done. Any suggestions for that?Reply
I changed it to BUGFIX because that is more accurate I think.Reply
DoneBreaking-84658-KeepSortingForDeletedRecords.rst:4ReplyChanged it to Important. Also set correct issue ref in this line. -
TYPO3com voted on patch set 2 V +1 04/09/18, 07:54 Completed build in 08m 15s on Mon, 9 Apr, 09:54 AM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22216
-
Mathias Brodala commented on patch set 2 04/09/18, 07:57
> (3 comments) > > Maybe this patch should be backported to TYPO3 8 but because of > breaking some functional tests in third party extensions, I'm not > sure if that should be done. > Any suggestions for that? Given the hassle this can cause I'd vote against backporting to v8. -
Mathias Brodala commented on patch set 2 V +1 CR +1 04/09/18, 07:58
Verified by Bamboo. -
Tim Schreiner commented on patch set 2 04/09/18, 08:01
> Patch Set 2: > > > (3 comments) > > > > Maybe this patch should be backported to TYPO3 8 but because of > > breaking some functional tests in third party extensions, I'm not > > sure if that should be done. > > Any suggestions for that? > > Given the hassle this can cause I'd vote against backporting to v8. Okay, that was also my thought. Then this change stays just for master -
Jan Stockfisch voted on patch set 2 V +1 04/09/18, 08:50
-
Georg Ringer voted on patch set 2 V +2 CR +2 04/09/18, 11:32
-
Georg Ringer merged patch set 3 04/09/18, 11:32