56612[BUGFIX] Fix extended search in indexed_search
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 1519
-
Helmut Hummel uploaded patch set 1 04/09/18, 13:34
-
Oliver Klee commented on patch set 1 CR -1 04/09/18, 13:36
The issue number is missing here. -
Oliver Klee commented on patch set 1 04/09/18, 13:37
SearchController.php:244Instead of making this method even longer, can we please move this block of code to a well-named private/protected method? -
TYPO3com voted on patch set 1 V +1 04/09/18, 13:44 Completed build in 09m 24s on Mon, 9 Apr, 03:44 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22221
-
Mathias Schreiber commented on patch set 1 04/09/18, 18:23
SearchController.php:244Replywould you hand over 12 parameters to such a method or rather go for an array? -
Oliver Klee commented on patch set 1 04/09/18, 18:38
SearchController.php:244ReplyNeither. As far as I can see, the block within the if does not need any outside variables, but works with methods and $this->view exclusively. Or am I missing something here? -
Georg Ringer uploaded patch set 2 04/10/18, 11:58
-
TYPO3com voted on patch set 2 V +1 04/10/18, 12:06 Completed build in 08m 00s on Tue, 10 Apr, 02:06 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22258
-
Jan Stockfisch commented on patch set 1 04/12/18, 12:09
SearchController.php:244ReplyThe block can be simply put into an own method. I will do that in a minute. -
Jan Stockfisch uploaded patch set 3 04/12/18, 12:24
-
TYPO3com voted on patch set 3 V +1 04/12/18, 12:32 Completed build in 08m 32s on Thu, 12 Apr, 02:32 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22280
-
Mathias Schreiber commented on patch set 3 CR +1 04/17/18, 07:35
SearchController.php:1635is this private on purpose? -
Jan Stockfisch commented on patch set 3 04/17/18, 08:23
SearchController.php:1635Reply UnresolvedNo it's not. Will change that in a moment -
Jan Stockfisch commented on patch set 4 04/17/18, 08:27
Published edit on patch set 3. -
Jan Stockfisch commented on patch set 4 CR -1 04/17/18, 08:28
Ticket ID is still missing -
TYPO3com voted on patch set 4 V +1 04/17/18, 08:38 Completed build in 10m 18s on Tue, 17 Apr, 10:38 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22444
-
Gianluca Piccolo commented on patch set 4 05/12/18, 13:27
This patch duplicates this older one: https://review.typo3.org/#/c/55547/. I think also that the other solution is better. -
Helmut Hummel commented on patch set 4 05/12/18, 14:22
Good point. did not see the old one -
Helmut Hummel abandoned the change 05/12/18, 14:22