Review main Abandoned

56612[BUGFIX] Fix extended search in indexed_search

Helmut Hummel CR 0 V 0 Normal +44 −35 updated 05/12/18, 14:22

Commit message

Always populate view data for extended search,
so that the select boxes work after searching something

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 1519

  1. Helmut Hummel uploaded patch set 1 04/09/18, 13:34

  2. Oliver Klee commented on patch set 1 CR -1 04/09/18, 13:36

    The issue number is missing here.
  3. Oliver Klee commented on patch set 1 04/09/18, 13:37

    SearchController.php:244

    Instead of making this method even longer, can we please move this block of code to a well-named private/protected method?
  4. TYPO3com voted on patch set 1 V +1 04/09/18, 13:44 Completed build in 09m 24s on Mon, 9 Apr, 03:44 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22221

  5. Mathias Schreiber commented on patch set 1 04/09/18, 18:23

    SearchController.php:244 Reply

    would you hand over 12 parameters to such a method or rather go for an array?
  6. Oliver Klee commented on patch set 1 04/09/18, 18:38

    SearchController.php:244 Reply

    Neither. As far as I can see, the block within the if does not need any outside variables, but works with methods and $this->view exclusively. Or am I missing something here?
  7. Georg Ringer uploaded patch set 2 04/10/18, 11:58

  8. TYPO3com voted on patch set 2 V +1 04/10/18, 12:06 Completed build in 08m 00s on Tue, 10 Apr, 02:06 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22258

  9. Jan Stockfisch commented on patch set 1 04/12/18, 12:09

    SearchController.php:244 Reply

    The block can be simply put into an own method. I will do that in a minute.
  10. Jan Stockfisch uploaded patch set 3 04/12/18, 12:24

  11. TYPO3com voted on patch set 3 V +1 04/12/18, 12:32 Completed build in 08m 32s on Thu, 12 Apr, 02:32 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22280

  12. Mathias Schreiber commented on patch set 3 CR +1 04/17/18, 07:35

    SearchController.php:1635

    is this private on purpose?
  13. Jan Stockfisch commented on patch set 3 04/17/18, 08:23

    SearchController.php:1635 Reply Unresolved

    No it's not. Will change that in a moment
  14. Jan Stockfisch commented on patch set 4 04/17/18, 08:27

    Published edit on patch set 3.
  15. Jan Stockfisch commented on patch set 4 CR -1 04/17/18, 08:28

    Ticket ID is still missing
  16. TYPO3com voted on patch set 4 V +1 04/17/18, 08:38 Completed build in 10m 18s on Tue, 17 Apr, 10:38 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22444

  17. Gianluca Piccolo commented on patch set 4 05/12/18, 13:27

    This patch duplicates this older one: https://review.typo3.org/#/c/55547/. I think also that the other solution is better.
  18. Helmut Hummel commented on patch set 4 05/12/18, 14:22

    Good point. did not see the old one
  19. Helmut Hummel abandoned the change 05/12/18, 14:22