Review main Merged

56616[BUGFIX] Handle empty absRefPrefix in PageLinkBuilder

Oliver Hader CR +2 V +2 Easy +1 −1 updated 04/09/18, 18:58

Commit message

Using empty values for absRefPrefix as needle in strpos() will
throw a warning. In order to avoid that, it's now checked more
explicitly if the prefixed slash originally was absRefPrefix.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Oliver Hader uploaded patch set 1 04/09/18, 18:14

  2. Mathias Schreiber voted on patch set 1 V +1 CR +1 04/09/18, 18:24

  3. Oliver Hader uploaded patch set 2 04/09/18, 18:24

  4. TYPO3com voted on patch set 1 V +1 04/09/18, 18:26 Completed build in 11m 21s on Mon, 9 Apr, 08:26 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22228

  5. TYPO3com voted on patch set 2 V +1 04/09/18, 18:34 Completed build in 09m 39s on Mon, 9 Apr, 08:34 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22230

  6. Wouter Wolters voted on patch set 2 CR +1 04/09/18, 18:43

  7. Susi Moog voted on patch set 2 V +1 CR +1 04/09/18, 18:51

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 04/09/18, 18:57

  9. Wouter Wolters merged patch set 3 04/09/18, 18:58