Review main Merged

56630[TASK] fix btn-group implementation

TYPO3com CR +2 V +2 Easy +3 −3 updated 05/11/18, 12:02

Commit message

The current btn-group implementation using spans results in :first-child
and :last-child not working correctly.
There is actually a workaround implemented in bootstrap itself which is
also necessary for using btn-group-justified.
Just add btn-group inside the btn-group.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Cristian Buja +1
    • Massimiliano Fani +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Cristian Buja +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. TYPO3com uploaded patch set 1 04/11/18, 14:27

  2. TYPO3com voted on patch set 1 V +1 04/11/18, 14:35 Completed build in 07m 59s on Wed, 11 Apr, 04:35 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22271

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 05/10/18, 11:15

  4. Massimiliano Fani voted on patch set 1 CR +1 05/10/18, 14:06

  5. Cristian Buja voted on patch set 1 V +1 CR +1 05/11/18, 09:50

  6. Frank Nägler voted on patch set 1 V +2 CR +2 05/11/18, 12:02

  7. Frank Nägler merged patch set 2 05/11/18, 12:02