Review main Abandoned

56636[BUGFIX] Allow int for optionValue in EXT:form

Stefan Froemken CR 0 V 0 Easy +1 −1 updated 06/08/18, 10:05

Commit message

Allow int values in EXT:form to successfully render
FlashMessages as their severity only allowes INT.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Stefan Froemken uploaded patch set 1 04/12/18, 12:01

  2. Stefan Froemken commented on patch set 1 04/12/18, 12:02

    This patch only solves the cast problem. FlashMessageFinisher has another bug in general. I will create another issue for that.
  3. TYPO3com voted on patch set 1 V +1 04/12/18, 12:09 Completed build in 08m 00s on Thu, 12 Apr, 02:09 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22279

  4. Ralf Zimmermann commented on patch set 1 04/17/18, 09:58

    Can you test if https://review.typo3.org/c/55820/ solves your problem? If yes, i prefer to abandoned this in favor of review:55820
  5. Kay Strobach commented on patch set 1 V -1 CR -1 04/17/18, 21:34

    please close that an followup in https://review.typo3.org/#/c/55820/
  6. Riccardo De Contardi commented on patch set 1 06/06/18, 21:51

    Abandoned - https://review.typo3.org/#/c/55820/ has been already merged
  7. Frank Nägler abandoned the change 06/08/18, 10:05

    abandon for the reasons mentioned in the comments. if anyone think this is wrong please add another comment.