56643[BUGFIX] Fix getPublicUrl return hints
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Wouter Wolters +1
- Frans Saris +1
-
Verified V +2
- Jigal van Hemert +2
- Frans Saris +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php+1 −1
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+1 −1
- typo3/sysext/core/Classes/Resource/File.php+2 −2
- typo3/sysext/core/Classes/Resource/FileInterface.php+1 −1
- typo3/sysext/core/Classes/Resource/FileReference.php+1 −1
- typo3/sysext/core/Classes/Resource/Folder.php+1 −1
- typo3/sysext/core/Classes/Resource/InaccessibleFolder.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/filelist/Classes/FileFacade.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.php+5 −0
Review log 1924
-
Kevin Ditscheid uploaded patch set 1 04/12/18, 18:12
-
TYPO3com voted on patch set 1 V +1 04/12/18, 18:22 Completed build in 09m 25s on Thu, 12 Apr, 08:22 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22295
-
Simon Gilli commented on patch set 1 CR -1 04/12/18, 18:38
The ancestor AbstractFile should be changed too! -
Simon Gilli commented on patch set 1 04/12/18, 18:42
Have a look at ResourceStorage->getPublicUrl and ResourceStorageInterface too -
Kevin Ditscheid commented on patch set 1 04/12/18, 19:55
I agree with ResourceStorage, but AbstractFile is hinting a possible NULL value return type. I am not sure what you mean about ResourceStorageInterface, because it does not contain getPublicUrl. Also there could be code that relies on the returning of NULL. -
Simon Gilli commented on patch set 1 04/13/18, 10:05
> Patch Set 1: > > I agree with ResourceStorage, but AbstractFile is hinting a possible NULL value return type. > I am not sure what you mean about ResourceStorageInterface, because it does not contain getPublicUrl. > > Also there could be code that relies on the returning of NULL. i don't know if it makes sense that AbstractFile returns NULL at all. and the two should be equal IMO i didn't check ResourceStorageInterface but thought could be defined there to. if not then everything is ok ;) i have searched the complete code for getPublicUrl and didn't find something that checks against NULL or '', the return value is never checked as far as i can see but always used as a string. -
Benni Mack commented on patch set 1 CR -2 04/13/18, 16:07
This patch misses a "Releases" line -
Kevin Ditscheid uploaded patch set 2 04/13/18, 18:55
-
TYPO3com voted on patch set 2 V -1 04/13/18, 19:04 Completed build in 08m 39s on Fri, 13 Apr, 09:04 PM Test Summary: 3 of 31100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22314
-
Kevin Ditscheid commented on patch set 2 04/13/18, 19:10
Man I am rusty, added the releases line. There are tests that check for NULL return value. So I would rather discuss this change with you guys, before I am changing more things here. -
Kevin Ditscheid uploaded patch set 3 04/14/18, 21:28
-
TYPO3com voted on patch set 3 V -1 04/14/18, 21:28 Completed build in 11s on Sat, 14 Apr, 11:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22343
-
Kevin Ditscheid uploaded patch set 4 04/14/18, 21:45
-
TYPO3com voted on patch set 4 V +1 04/14/18, 21:54 Completed build in 09m 00s on Sat, 14 Apr, 11:54 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22344
-
Benni Mack voted on patch set 4 CR 0 04/15/18, 08:35
-
Benni Mack voted on patch set 4 CR +1 04/15/18, 08:36
-
Oliver Klee voted on patch set 4 CR +1 04/15/18, 08:42
-
Frans Saris updated the commit message in patch set 5 04/15/18, 09:42
-
Frans Saris voted on patch set 5 V +1 CR +1 04/15/18, 09:46
-
TYPO3com voted on patch set 5 V +1 04/15/18, 09:51 Completed build in 08m 47s on Sun, 15 Apr, 11:51 AM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22352
-
Wouter Wolters voted on patch set 5 CR +1 04/15/18, 11:00
-
Jigal van Hemert voted on patch set 5 V +2 CR +2 04/15/18, 20:49
-
Jigal van Hemert merged patch set 6 04/15/18, 20:50
-
Jigal van Hemert commented on patch set 6 04/15/18, 20:50
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 23df333368cad5f590790ea5caaa3aed58a44d8f